Fix hanging when prompt exceeds limit #1029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that my API server with AsyncLLMEngine was blocked when a lengthy prompt was submitted to it. This problem shares similarities with issues #765 and #1026.
The scheduler is adding seq_groups that are larger than the prompt_limit:
And it returns when the schedule is not empty:
However, in
LLMEngine._schedule
,ignored_seq_groups
is returned whenscheduler_outputs.is_empty()
.The third value returned by
LLMEngine._schedule
will always be None, and the ignored seq groups are thus LEAKED.