Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] [CI]: Flaky test failure in test_chatglm3_lora #3947

Closed
cadedaniel opened this issue Apr 9, 2024 · 2 comments
Closed

[Misc] [CI]: Flaky test failure in test_chatglm3_lora #3947

cadedaniel opened this issue Apr 9, 2024 · 2 comments
Assignees
Labels

Comments

@cadedaniel
Copy link
Collaborator

cadedaniel commented Apr 9, 2024

    def test_chatglm3_lora(chatglm3_lora_files):
        llm = vllm.LLM(MODEL_PATH,
                       max_model_len=1024,
                       enable_lora=True,
                       max_loras=4,
                       max_lora_rank=64,
                       trust_remote_code=True)

        expected_lora_output = [
            "SELECT count(*) FROM singer",
            "SELECT avg(age) ,  min(age) ,  max(age) FROM singer WHERE country  =  'France'",  # noqa: E501
            "SELECT name ,  country ,  age FROM singer ORDER BY age",
        ]

        output1 = do_sample(llm, chatglm3_lora_files, lora_id=1)
        for i in range(len(expected_lora_output)):
            assert output1[i] == expected_lora_output[i]
        output2 = do_sample(llm, chatglm3_lora_files, lora_id=2)
        for i in range(len(expected_lora_output)):
>           assert output2[i] == expected_lora_output[i]
E           AssertionError: assert '' == 'SELECT count(*) FROM singer'
E             
E             - SELECT count(*) FROM singer
@cadedaniel cadedaniel added the misc label Apr 9, 2024
@cadedaniel cadedaniel self-assigned this Apr 9, 2024
@youkaichao
Copy link
Member

I re-tried the test and it passed. Should be a flaky one.

@cadedaniel cadedaniel changed the title [Misc] [CI]: Unexpected main branch test failure in test_chatglm3_lora [Misc] [CI]: Flaky test failure in test_chatglm3_lora Apr 9, 2024
@cadedaniel
Copy link
Collaborator Author

thanks for that @youkaichao . let's reopen this issue if it happens again -- we can skip the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants