Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Contribution: Support ChatGLM3 #1552

Closed
simon-mo opened this issue Nov 2, 2023 · 3 comments
Closed

Call for Contribution: Support ChatGLM3 #1552

simon-mo opened this issue Nov 2, 2023 · 3 comments

Comments

@simon-mo
Copy link
Collaborator

simon-mo commented Nov 2, 2023

Hi vLLM community,

We are aware of the enthusiasm (#247 #231) to add support for ChatGLM model. However, the team is currently overwhelmed by other higher priorities work like improving latency and enhance quantization.

Currently, there are total of five stale PRs, each in different states, none of them are mergable.
#1477
#1261
#1109
#649
#625

I believe we can directly support https://github.com/THUDM/ChatGLM3. We are looking for people who can help us take the model to completion. We will do our best in reviewing your PRs and support your contribution.

Contribution guide here: https://vllm.readthedocs.io/en/latest/models/adding_model.html

@simon-mo simon-mo changed the title Call for Contribution: ChatGLM Model [VLLM-11] Call for Contribution: ChatGLM Model Nov 2, 2023
@simon-mo simon-mo changed the title [VLLM-11] Call for Contribution: ChatGLM Model Call for Contribution: ChatGLM Model Nov 2, 2023
@simon-mo simon-mo changed the title Call for Contribution: ChatGLM Model Call for Contribution: Support ChatGLM3 Nov 2, 2023
@simon-mo simon-mo changed the title Call for Contribution: Support ChatGLM3 [VLLM-11] Call for Contribution: Support ChatGLM3 Nov 2, 2023
@simon-mo simon-mo changed the title [VLLM-11] Call for Contribution: Support ChatGLM3 Call for Contribution: Support ChatGLM3 Nov 2, 2023
@felixdae
Copy link

felixdae commented Nov 5, 2023

now we have one more, could you please review it @simon-mo
#1558

@simon-mo
Copy link
Collaborator Author

simon-mo commented Nov 6, 2023

@felixdae thank you for that. The teams is taking a look at both #1558
and #1261

@simon-mo
Copy link
Collaborator Author

simon-mo commented Nov 7, 2023

It is now supported via #1261

@simon-mo simon-mo closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants