Question about this repo especially

[sirlupinwatson]

Hi all hope you are doing great! @russellb got a genuine question for you.
I was wondering how this issue might have arise, is it since there was a pull request made in this file repository or since it only trigger the library and those work in a similar framework as in "parallel" instances with another repo in some way?

I am trying to understand how this is even possible, if you host on GitHub and you maintain this repo?
To get the actual perpetrator from huggingface it should be easy at this point as this vulnerability is a high risk and should be taken care as fast as possible.

I am simply trying to help and I realize that there was a load of security issue and vulnerability so I felf on this one. Nothing personal here just trying to figure this out as I said.

Have a great evening!

[russellb]

@sirlupinwatson, apologies, but I'm afraid I don't understand your question. Can you provide some more context?

[sirlupinwatson]

What I am trying to explain is that the call made to model_weights_iterator can be solve by using a common separator and never be accesses and only called from internal function. Problem solved.

But I was worried about how this issue can arise from huggingface as mention in your post, as this fetch can only arise when the pickle is unpickling and from there the natural form of the "arbitration" arise.

Exsuxe myself I taught for a moment that you were the actual owner and project manager from this repository or package.

I had not read the part where you mention: "Note that most models now use the safetensors format, which is not vulnerable to this issue." and thanks for reporting it.

I've seen an increased amount in term of "funny" user who actually try to inject code and use fraudulent patterns to obfuscate or mislead repository or common project and to me this is a serious problem as it will only take 1 to infest the nest, which I try to avoid...

Thanks for your work! Keep it up!