Skip to content

Commit f52445d

Browse files
committed
switch to reuse ready_check_timeout_sec=0
Signed-off-by: Lu Fang <fanglu@fb.com>
1 parent 9517382 commit f52445d

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

vllm/benchmarks/serve.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,6 @@ async def benchmark(
476476
ramp_up_start_rps: Optional[int] = None,
477477
ramp_up_end_rps: Optional[int] = None,
478478
ready_check_timeout_sec: int = 600,
479-
skip_ready_check: bool = False,
480479
):
481480
task_type = (TaskType.EMBEDDING if api_url.endswith("/v1/embeddings") else
482481
TaskType.GENERATION)
@@ -532,7 +531,7 @@ async def benchmark(
532531
extra_body=extra_body,
533532
)
534533

535-
if not skip_ready_check:
534+
if ready_check_timeout_sec > 0:
536535
test_output = await wait_for_endpoint(
537536
request_func,
538537
test_input,
@@ -541,12 +540,13 @@ async def benchmark(
541540
)
542541
if not test_output.success:
543542
raise ValueError(
544-
"Initial test run failed - Please make sure benchmark arguments "
545-
f"are correctly specified. Error: {test_output.error}")
543+
"Initial test run failed - Please make sure benchmark "
544+
"arguments are correctly specified. "
545+
f"Error: {test_output.error}")
546546
else:
547547
print("Initial test run completed. Starting main benchmark run...")
548548
else:
549-
print("Skipping ready check as requested.")
549+
print("Skipping endpoint ready check.")
550550

551551
if lora_modules:
552552
# For each input request, choose a LoRA module at random.
@@ -1155,13 +1155,8 @@ def add_cli_args(parser: argparse.ArgumentParser):
11551155
type=int,
11561156
default=600,
11571157
help="Maximum time to wait for the endpoint to become ready "
1158-
"in seconds (default: 600 seconds / 10 minutes).",
1159-
)
1160-
parser.add_argument(
1161-
"--skip-ready-check",
1162-
action="store_true",
1163-
help="Skip the ready check. This is useful when the endpoint "
1164-
"is already ready and the ready check is not needed.",
1158+
"in seconds (default: 600 seconds / 10 minutes). If set to 0, "
1159+
"the ready check will be skipped."
11651160
)
11661161

11671162

@@ -1282,7 +1277,6 @@ async def main_async(args: argparse.Namespace) -> dict[str, Any]:
12821277
ramp_up_start_rps=args.ramp_up_start_rps,
12831278
ramp_up_end_rps=args.ramp_up_end_rps,
12841279
ready_check_timeout_sec=args.ready_check_timeout_sec,
1285-
skip_ready_check=args.skip_ready_check,
12861280
)
12871281

12881282
# Save config and results to json

0 commit comments

Comments
 (0)