Skip to content

Commit

Permalink
[Misc] Limit to ray[adag] 2.35 to avoid backward incompatible change (#…
Browse files Browse the repository at this point in the history
…8509)

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
  • Loading branch information
ruisearch42 authored Sep 17, 2024
1 parent 99aa4ed commit cbdb252
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ librosa # required for audio test
opencv-python # required for video test
peft
requests
ray[adag]>=2.35
ray[adag]==2.35
sentence-transformers # required for embedding
soundfile # required for audio test
compressed-tensors==0.4.0 # required for compressed-tensors
Expand Down
6 changes: 4 additions & 2 deletions vllm/executor/ray_gpu_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,10 @@ def _check_ray_adag_installation(self):
required_version = version.parse("2.35")
current_version = version.parse(
pkg_resources.get_distribution("ray").version)
if current_version < required_version:
raise ValueError(f"Ray version {required_version} or greater is "
# TODO: update the constraint once we adapt to the backward
# incompatible API change from ray 2.36
if current_version != required_version:
raise ValueError(f"Ray version {required_version} is "
f"required, but found {current_version}")

import importlib.util
Expand Down

0 comments on commit cbdb252

Please sign in to comment.