-
Notifications
You must be signed in to change notification settings - Fork 530
[CI] Upgrade vllm to 0.11.1 #3499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Icey <1790571317@qq.com>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
Upgrade vllm to newest commit: #3423 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades vllm to version 0.11.1 and adapts the vllm-ascend codebase to the API changes. The changes correctly address several breaking changes in the new version. However, I've found a critical issue with the version checking mechanism. The function vllm_version_is performs an exact version match, which is not robust for ensuring compatibility across different vllm versions. This could lead to runtime errors if used with versions other than the exact ones specified. This issue is present in multiple files and needs to be addressed to ensure the code is resilient to version changes.
Signed-off-by: Icey <1790571317@qq.com>
What this PR does / why we need it?
Upgrade vllm to 0.11.1
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI passed with new added/existing test.