Skip to content

Conversation

@wxsIcey
Copy link
Collaborator

@wxsIcey wxsIcey commented Oct 16, 2025

What this PR does / why we need it?

Upgrade vllm to 0.11.1

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI passed with new added/existing test.

Signed-off-by: Icey <1790571317@qq.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wxsIcey
Copy link
Collaborator Author

wxsIcey commented Oct 16, 2025

Upgrade vllm to newest commit: #3423

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades vllm to version 0.11.1 and adapts the vllm-ascend codebase to the API changes. The changes correctly address several breaking changes in the new version. However, I've found a critical issue with the version checking mechanism. The function vllm_version_is performs an exact version match, which is not robust for ensuring compatibility across different vllm versions. This could lead to runtime errors if used with versions other than the exact ones specified. This issue is present in multiple files and needs to be addressed to ensure the code is resilient to version changes.

Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
@wxsIcey wxsIcey closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants