Skip to content

Commit c6d2fc2

Browse files
authored
Merge pull request #93 from Shaoting-Feng/pr-template
[Doc] Add PR template
2 parents 1030c21 + b484052 commit c6d2fc2

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
FILL IN THE PR DESCRIPTION HERE
2+
3+
FIX #xxxx (*link existing issues this PR will resolve*)
4+
5+
**BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE**
6+
7+
---
8+
9+
<details>
10+
<!-- inside this <details> section, markdown rendering does not work, so we use raw html here. -->
11+
<summary><b> PR Checklist (Click to Expand) </b></summary>
12+
13+
<p>Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.</p>
14+
15+
<h3>PR Title and Classification</h3>
16+
<p>Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:</p>
17+
<ul>
18+
<li><code>[Bugfix]</code> for bug fixes.</li>
19+
<li><code>[CI/Build]</code> for build or continuous integration improvements.</li>
20+
<li><code>[Doc]</code> for documentation fixes and improvements.</li>
21+
<li><code>[Feat]</code> for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).</li>
22+
<li><code>[Router]</code> for changes to the <code>vllm_router</code> (e.g., routing algorithm, router observability, etc.).</li>
23+
<li><code>[Misc]</code> for PRs that do not fit the above categories. Please use this sparingly.</li>
24+
</ul>
25+
<p><strong>Note:</strong> If the PR spans more than one category, please include all relevant prefixes.</p>
26+
27+
<h3>Code Quality</h3>
28+
29+
<p>The PR need to meet the following code quality standards:</p>
30+
31+
<ul>
32+
<li>Pass all linter checks. Please use <code>pre-commit</code> to format your code. See <code>README.md</code> for installation.</li>
33+
<li>The code need to be well-documented to ensure future contributors can easily understand the code.</li>
34+
<li> Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.</li>
35+
</ul>
36+
37+
<h3>DCO and Signed-off-by</h3>
38+
<p>When contributing changes to this project, you must agree to the <a href="https://github.com/vllm-project/vllm/blob/main/DCO">DCO</a>. Commits must include a <code>Signed-off-by:</code> header which certifies agreement with the terms of the DCO.</p>
39+
<p>Using <code>-s</code> with <code>git commit</code> will automatically add this header.</p>
40+
41+
<h3>What to Expect for the Reviews</h3>
42+
43+
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
44+
, Shaoting-Feng or ApostaC.

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ repos:
4141
rev: v0.44.0
4242
hooks:
4343
- id: markdownlint
44+
exclude: ".github/PULL_REQUEST_TEMPLATE.md"
4445
- repo: https://github.com/codespell-project/codespell
4546
rev: v2.4.1
4647
hooks:

0 commit comments

Comments
 (0)