Skip to content

Conversation

tukwila
Copy link
Contributor

@tukwila tukwila commented Sep 4, 2025

Summary

Older logger style is not clear to display which function:line_number to executed so that i append function_name and line_number and color the print. Refer to:

image

Details

  • [ ]

Test Plan

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjmonson sjmonson merged commit 0e3966b into vllm-project:main Sep 4, 2025
17 checks passed
@tukwila tukwila deleted the format_logger branch September 5, 2025 08:25
sjmonson added a commit that referenced this pull request Sep 23, 2025
sjmonson added a commit that referenced this pull request Sep 23, 2025
Signed-off-by: Samuel Monson <smonson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants