💚 Linter is happy

Author: Dmytro Parfeniuk

pyproject.toml

@@ -104,6 +104,10 @@ exclude = ["venv", ".tox"]
 # Check: https://mypy.readthedocs.io/en/latest/config_file.html#import-discovery
 follow_imports = 'silent'
 
+[[tool.mypy.overrides]]
+module = ["datasets.*"]
+ignore_missing_imports=true
+
 
 [tool.ruff]
 line-length = 88
@@ -122,6 +126,8 @@ ignore = [
     "ISC001",
     "TCH002",
     "PLW1514", # allow Path.open without encoding
+    "RET505", # allow `else` blocks
+    "RET506" # allow `else` blocks
 
 ]
 select = [

src/guidellm/request/transformers.py

@@ -1,8 +1,12 @@
 from pathlib import Path
 from typing import Optional, Union
 
-from datasets import DatasetDict  # type: ignore  # noqa: PGH003
-from datasets import Dataset, IterableDataset, IterableDatasetDict
+from datasets import (
+    Dataset,
+    DatasetDict,  # type: ignore  # noqa: PGH003
+    IterableDataset,
+    IterableDatasetDict,
+)
 from loguru import logger
 from transformers import PreTrainedTokenizer  # type: ignore  # noqa: PGH003
 
@@ -73,7 +77,7 @@ def __init__(
 
     def __len__(self) -> int:
         if not isinstance(self._hf_dataset, Dataset):
-            raise ValueError(f"Can't get dataset size for IterableDataset object")
+            raise ValueError("Can't get dataset size for IterableDataset object")
         else:
             return len(self._hf_dataset)
 

src/guidellm/utils/cli_params.py

@@ -23,8 +23,7 @@ def convert(
             return value
 
         try:
-            value = int(value)
-            return value
+            return int(value)
         except ValueError:
             if value == "dataset":
                 return value

tests/unit/cli/test_custom_type_params.py

@@ -4,7 +4,7 @@
 from guidellm.utils import cli_params
 
 
-@pytest.fixture
+@pytest.fixture()
 def max_requests_param_type():
     return cli_params.MaxRequestsType()
 

tests/unit/test_main.py

@@ -279,9 +279,9 @@ def test_generate_benchmark_report_emulated_with_dataset_requests(
 def test_generate_benchmark_report_cli_emulated_with_dataset_requests(
     mock_backend, mock_request_generator_emulated, mock_executor
 ):
+    runner = CliRunner()
     with pytest.raises(ValueError, match="Cannot use 'dataset' for emulated data"):
-        runner = CliRunner()
-        result = runner.invoke(
+        runner.invoke(
             generate_benchmark_report_cli,
             [
                 "--target",
@@ -303,6 +303,3 @@ def test_generate_benchmark_report_cli_emulated_with_dataset_requests(
             ],
             catch_exceptions=False,
         )
-
-        if result.stdout:
-            print(result.stdout)  # noqa: T201