early and better error for divisibility issues #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary Adding divisibility check for block and group quantization Signed-off-by: HDCharles <charlesdavidhernandez@gmail.com>
brian-dellabetta
approved these changes
Nov 6, 2025
Collaborator
brian-dellabetta
left a comment
brian-dellabetta
left a comment
There was a problem hiding this comment.
Nice, I think this is preferable to the previous closed PR. One comment:
| return target_to_scheme[targets[0]] | ||
|
|
||
|
|
||
| def _validate_group_or_block_size(modules: list[tuple[str, Module]]) -> None: |
Collaborator
There was a problem hiding this comment.
I think the type is incorrect for match_named_modules output
Suggested change
| def _validate_group_or_block_size(modules: list[tuple[str, Module]]) -> None: | |
| def _validate_group_or_block_size(modules: Generator[tuple[str, Module]]) -> None: |
kylesayrs
requested changes
Nov 10, 2025
Collaborator
kylesayrs
left a comment
kylesayrs
left a comment
There was a problem hiding this comment.
Clarifying some things...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding divisibility check for block and group quantization to improve UX
solves vllm-project/llm-compressor#1983