chore: improve build cleanliness

Author: GaspardKirira

tests/app/app_constructor_test.cpp

@@ -100,13 +100,9 @@ namespace
 
     assert(app.router() != nullptr);
 
-    /*
-     * These accessors return references. Taking their address verifies that
-     * the objects are present and usable without starting the server.
-     */
-    assert(&app.config() != nullptr);
-    assert(&app.server() != nullptr);
-    assert(&app.executor() != nullptr);
+    (void)app.config();
+    (void)app.server();
+    (void)app.executor();
 
     app.close();
   }

tests/app/app_lifecycle_test.cpp

@@ -1083,7 +1083,7 @@ namespace
 
     close_and_wait(app);
 
-    assert(&app.executor() != nullptr);
+    (void)app.executor();
   }
 
   static void test_listen_after_manual_close_keeps_app_stopped()

tests/app/app_middleware_test.cpp

@@ -89,26 +89,7 @@ namespace
     };
   }
 
-  static bool has_record(
-      const std::vector<RouteRecord> &records,
-      const std::string &method,
-      const std::string &path,
-      bool heavy = false)
-  {
-    for (const auto &record : records)
-    {
-      if (record.method == method &&
-          record.path == path &&
-          record.heavy == heavy)
-      {
-        return true;
-      }
-    }
-
-    return false;
-  }
-
-  static std::size_t count_records(
+static std::size_t count_records(
       const std::vector<RouteRecord> &records,
       const std::string &method,
       const std::string &path)

tests/app/app_static_dir_test.cpp

@@ -127,23 +127,11 @@ namespace
   static App &register_static_dir(
       App &app,
       const std::filesystem::path &root,
-      const std::string &mount = "/")
-  {
-    std::filesystem::path mutable_root = root;
-
-    app.static_dir(mutable_root, mount);
-
-    return app;
-  }
-
-  static App &register_static_dir(
-      App &app,
-      const std::filesystem::path &root,
-      const std::string &mount,
-      const std::string &index_file,
-      bool add_cache_control,
-      const std::string &cache_control,
-      bool fallthrough)
+      const std::string &mount = "/",
+      const std::string &index_file = "index.html",
+      bool add_cache_control = false,
+      const std::string &cache_control = "",
+      bool fallthrough = false)
   {
     std::filesystem::path mutable_root = root;
 

tests/app/app_static_hook_test.cpp

@@ -127,16 +127,7 @@ namespace
     assert(app.router()->has_route(method, path) == true);
   }
 
-  static void assert_route_not_registered(
-      App &app,
-      const std::string &method,
-      const std::string &path)
-  {
-    assert(app.router() != nullptr);
-    assert(app.router()->has_route(method, path) == false);
-  }
-
-  struct StaticHandlerCall
+struct StaticHandlerCall
   {
     bool called{false};
     App *app{nullptr};

tests/config/config_copy_move_test.cpp

@@ -108,22 +108,7 @@ namespace
     return dir / ".env";
   }
 
-  static std::filesystem::path make_env_file(const std::string &content)
-  {
-    const std::filesystem::path path = make_empty_env_path();
-
-    std::ofstream out(path, std::ios::binary | std::ios::trunc);
-    assert(out);
-
-    out << content;
-    out.close();
-
-    assert(std::filesystem::exists(path));
-
-    return path;
-  }
-
-  static Config make_config_from_current_env()
+static Config make_config_from_current_env()
   {
     const std::filesystem::path env_path = make_empty_env_path();
 

tests/router/router_dispatch_test.cpp

@@ -192,12 +192,7 @@ namespace
     return result;
   }
 
-  static bool contains(const std::string &text, const std::string &needle)
-  {
-    return text.find(needle) != std::string::npos;
-  }
-
-  static vix::json::Json parse_body(const Response &res)
+static vix::json::Json parse_body(const Response &res)
   {
     return vix::json::loads(res.body());
   }

tests/runtime/bench_threadpool_vs_runtime.cpp

@@ -56,7 +56,7 @@ namespace
     const auto end = Clock::now();
 
     const double elapsedMs =
-        std::chrono::duration_cast<Ns>(end - start).count() / 1'000'000.0;
+        static_cast<double>(std::chrono::duration_cast<Ns>(end - start).count()) / 1'000'000.0;
 
     const double opsPerSec =
         (elapsedMs <= 0.0) ? 0.0 : (static_cast<double>(operations) * 1000.0 / elapsedMs);

tests/session/session_error_test.cpp

@@ -144,7 +144,6 @@ namespace
         Response &) override
     {
       throw std::runtime_error("handler failed");
-      co_return;
     }
   };