Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rancher/system-upgrade-controller:latest doesn't exist #370

Closed
MuhanedYahya opened this issue May 30, 2024 · 9 comments
Closed

rancher/system-upgrade-controller:latest doesn't exist #370

MuhanedYahya opened this issue May 30, 2024 · 9 comments

Comments

@MuhanedYahya
Copy link

MuhanedYahya commented May 30, 2024

Pod Logs:

  Normal   Pulling           23m (x4 over 24m)     kubelet            Pulling image "rancher/system-upgrade-controller:latest"
  Warning  Failed            23m (x4 over 24m)     kubelet            Failed to pull image "rancher/system-upgrade-controller:latest": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/rancher/system-upgrade-controller:latest": failed to resolve reference "docker.io/rancher/system-upgrade-controller:latest": docker.io/rancher/system-upgrade-controller:latest: not found
@khustochka
Copy link
Contributor

This is a rancher issue: rancher/system-upgrade-controller#302

@jerve
Copy link

jerve commented May 31, 2024

I guess this could be worked around by defining the system_upgrade_controller_crd_manifest_url in the settings pointing to a tag that is not "latest" anyway, as this is considered bad practice.

@creib
Copy link
Contributor

creib commented Jul 22, 2024

Adding these two lines did not fix it for me

system_upgrade_controller_deployment_manifest_url: "https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/system-upgrade-controller.yaml"
system_upgrade_controller_crd_manifest_url: "https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/crd.yaml"

Do I miss something?

@vitobotta
Copy link
Owner

Adding these two lines did not fix it for me

system_upgrade_controller_deployment_manifest_url: "https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/system-upgrade-controller.yaml"
system_upgrade_controller_crd_manifest_url: "https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/crd.yaml"

Do I miss something?

These are the versions I am using with v2 under development and they seem to be working fine for me. Do the images get pulled or not at all?

@creib
Copy link
Contributor

creib commented Jul 22, 2024

When adding the lines to the config and running hetzner-k3s create, the system-upgrade-controller gets again deployed with the latest version. If I change it in the deployment to v0.13.4 it gets pulled and it is running.
I am using version 1.1.5.

@vitobotta
Copy link
Owner

When adding the lines to the config and running hetzner-k3s create, the system-upgrade-controller gets again deployed with the latest version. If I change it in the deployment to v0.13.4 it gets pulled and it is running. I am using version 1.1.5.

Oh, this is my bad, sorry. The actual name of the setting in the current stable version is system_upgrade_controller_manifest_url; by mistake I recently merged the WIP branch for v2 into main, so I can see that this can cause confusion when reading the README.

Please try the system_upgrade_controller_manifest_url setting instead. I'll see if I can revert the README in main if I cannot finalize v2 soon enough. Sorry for the confusion.

@creib
Copy link
Contributor

creib commented Jul 22, 2024

system_upgrade_controller_manifest_url: "https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/system-upgrade-controller.yaml"
Works also perfect, thank again!

@vitobotta
Copy link
Owner

system_upgrade_controller_manifest_url: "https://github.com/rancher/system-upgrade-controller/releases/download/v0.13.4/system-upgrade-controller.yaml" Works also perfect, thank again!

Cool, sorry again for the confusion :)

@vitobotta
Copy link
Owner

Closing since improvements have been made in v2, which is going to be released probably this weekend or anyway pretty soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants