Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors not diplayed in vscode with Vitest 1.0.1 #198

Closed
groomain opened this issue Dec 6, 2023 · 8 comments
Closed

Errors not diplayed in vscode with Vitest 1.0.1 #198

groomain opened this issue Dec 6, 2023 · 8 comments
Labels
duplicate This issue or pull request already exists p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@groomain
Copy link

groomain commented Dec 6, 2023

Describe the bug
Errors are empty with vitest v1.0.1.
It's working when I got back to an older version

To Reproduce
Install vitest v1.0.1 and you'll not have the errors displayed in vscode. It's working with vitest v0.35.6

Expected behavior
Display inline errors in vscode

Screenshots
Capture d’écran 2023-12-06 à 11 22 40

Environment

(Paste info.txt content generated by the example project)

  • OS: macOD
  • VSCode version: 1.84.2
  • Vitest version: 1.0.1
  • Vitest plugin version: 0.2.43
@groomain groomain added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 6, 2023
@mzietlow
Copy link

mzietlow commented Dec 7, 2023

We are experiencing the same bug on Windows with Vitest version 1.0.2

@SonyStone
Copy link

SonyStone commented Dec 13, 2023

Same issue with Vitest 1.0.4
image

  • OS: Windows 11
  • VSCode vesrion 1.84.2
  • Vitest 1.0.4
  • Vitest plugin version: 0.2.43

Working with Vitest 0.34.6
image

@TonyLomartire
Copy link

Also ran into this on macOS, downgrading resolved.

@snake-poison
Copy link

Running into the same issue and after downgrading/upgrading a few times I narrowed down the breaking change in vitest to have been introduced in version vitest@1.0.0-beta.3. The latest version that is unaffected by this issue is vitest@1.0.0-beta.2.

@brion-fuller
Copy link

brion-fuller commented Jan 16, 2024

It looks to be a difference in TaskResult. The property error was changes to errors.https://github.com/vitest-dev/vitest/blob/39814357024e96b81546ec22d6aaf777b8db6cef/packages/runner/src/types/tasks.ts#L37
Looks like this property was deprecated from this change vitest-dev/vitest@482b72f#diff-4e87df9f7a0c8e9da1c78c0e04171f3c5b59346f636eb7be22462b53cb19761b

I have a branch that has a working model. My main question before a PR is are we trying to be backwards compatible? Or will this tool be mapped to various major versons of vite? I would assume we would want to avoid additional support needed for older versions.

@jd1378
Copy link

jd1378 commented Jan 21, 2024

what's the immediate action we can take to solve the issue locally for now until this is fixed ?

@cbush06
Copy link

cbush06 commented Feb 3, 2024

I'm having the same issue. Please fix! This is such a great plugin.

@MilanKovacic MilanKovacic added the duplicate This issue or pull request already exists label Feb 15, 2024
@MilanKovacic
Copy link
Collaborator

Extension was not updated to properly work with vitest >= 1.0.0. Fixed by #213.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

No branches or pull requests

9 participants