Skip to content

fix: type regression in vi.mocked() static class methods #9857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 2 commits into from
Mar 17, 2026
+10 −6
Merged

fix: type regression in vi.mocked() static class methods #9857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
234b0dd
fix: type regression in vi.mocked() static class methods
purepear Mar 12, 2026
b4bc422
Merge branch 'main' into fix/type-regression-mocked-static-class-methods
hi-ogawa Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/spy/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,12 +462,10 @@ type DeepPartialMock<T extends Procedure | Constructable = Procedure> = Mock<
export type MaybeMockedConstructor<T> = T extends Constructable
? Mock<T>
: T
export type MockedFunction<T extends Procedure | Constructable> = Mock<T> & {
[K in keyof T]: T[K];
}
export type PartiallyMockedFunction<T extends Procedure | Constructable> = PartialMock<T> & {
[K in keyof T]: T[K];
}
export type MockedFunction<T extends Procedure | Constructable> = Mock<T>
& MockedObject<T>
export type PartiallyMockedFunction<T extends Procedure | Constructable> = PartialMock<T>
& MockedObject<T>
export type MockedFunctionDeep<T extends Procedure | Constructable> = Mock<T>
& MockedObjectDeep<T>
export type PartiallyMockedFunctionDeep<T extends Procedure | Constructable> = DeepPartialMock<T>
Expand Down
6 changes: 6 additions & 0 deletions test/core/test/vi.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ describe('testing vi utils', () => {
public getBar(): string {
return this.bar
}

static getBaz(): string {
return 'baz'
}
}
class FooMock implements Mocked<Foo> {
readonly barMock: Mock<() => string> = vi.fn()
Expand All @@ -168,6 +172,8 @@ describe('testing vi utils', () => {
if (0) {
vi.mocked(Foo).mockImplementation(FooMock)
vi.mocked(Foo).mockImplementation(Foo)
vi.mocked(Foo).getBaz.mockImplementation(() => 'baz')
vi.mocked(Foo, { partial: true }).getBaz.mockImplementation(() => 'baz')
}
})

Expand Down
Loading