refactor!: replace loupe.inspect with pretty-format
#9609
+58
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pretty-formatandinspect#9582Question
loupe is used for
test.for/eachtitle formatting. any changes there is a breaking change as it tends to effect snapshot key name. Is it a goal to port exact currentloupeformat to pretty-format? e.g. loupe is single quote, but pretty-format is double quote. It's rather simple to port single/double quote to pretty-format, but is it necessary to try to align?my optinion: we can align quote, which should cover most of compatibility. but don't need to try to aim exact match regarding truncation (loupe has
truncate: number) andObject.keys/getOwnPropertyNamesbehavior difference.References of past loupe related issues
objDisplaydefault truncate option fortest.eachtitle #4917Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.