Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 8, 2026

Description

Question

loupe is used for test.for/each title formatting. any changes there is a breaking change as it tends to effect snapshot key name. Is it a goal to port exact current loupe format to pretty-format? e.g. loupe is single quote, but pretty-format is double quote. It's rather simple to port single/double quote to pretty-format, but is it necessary to try to align?

my optinion: we can align quote, which should cover most of compatibility. but don't need to try to aim exact match regarding truncation (loupe has truncate: number) and Object.keys/getOwnPropertyNames behavior difference.

References of past loupe related issues

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa changed the title refactor: replace loupe.inspect with pretty-format refactor!: replace loupe.inspect with pretty-format Feb 8, 2026
@hi-ogawa hi-ogawa self-assigned this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant