Skip to content

fix(reporter): --hideSkippedTests should hide suites too #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Mar 18, 2025

Description

  • Skipped suites should be hidden when --hideSkippedTests is used.

Noticed this verbose noise in my project even when using hideSkippedTests: true:

With this fix it becomes much easier to read:

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eca4f94
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67d98fb3e28cf80008e11785
😎 Deploy Preview https://deploy-preview-7695--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the fix/hide-skipped-tests-hide-suites branch from eca4f94 to 32908a1 Compare March 18, 2025 15:49
@AriPerkkio AriPerkkio marked this pull request as ready for review March 18, 2025 15:52
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Btw, I haven't notice the issue with the default reporter, so is this only for verbose reporter?

@AriPerkkio
Copy link
Member Author

Yes, I think this affects only verbose reporter. The default/base reporter renders tests and their suites on the same line, so hiding affects whole row.

This issue came up only after #7503.

@hi-ogawa hi-ogawa merged commit ba9b51c into vitest-dev:main Mar 19, 2025
21 of 22 checks passed
@AriPerkkio AriPerkkio deleted the fix/hide-skipped-tests-hide-suites branch March 19, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants