fix: fix error diff of toBeNaN, toBeUndefined, toBeNull, toBeTruthy, toBeFalsy
#6697
+119
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Oct 12, 2024
Comment on lines
+389
to
+396
| const obj = utils.flag(this, 'object') | ||
| this.assert( | ||
| undefined === obj, | ||
| 'expected #{this} to be undefined', | ||
| 'expected #{this} not to be undefined', | ||
| undefined, | ||
| obj, | ||
| ) |
There was a problem hiding this comment.
Chai's .be.undefined doesn't include diff https://github.com/chaijs/chai/blob/1b1780582c07eefb3781333e24316865b9db7ae8/lib/chai/core/assertions.js#L830-L836, so I copied these three from chai and added expected (4th arg) and actual (5th arg)
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
approved these changes
Oct 12, 2024
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Oct 14, 2024
##### [v2.1.3](https://github.com/vitest-dev/vitest/releases/tag/v2.1.3) ##### 🐞 Bug Fixes - Fix error diff of `toBeNaN, toBeUndefined, toBeNull, toBeTruthy, toBeFalsy` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6697 [<samp>(e0027)</samp>](vitest-dev/vitest@e002758c) - **browser**: - Provide aria role intellisense - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6629 [<samp>(f36ea)</samp>](vitest-dev/vitest@f36eac77) - Not.toBeInTheDocument works with locators API - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6634 [<samp>(8bef5)</samp>](vitest-dev/vitest@8bef5d2b) - Use `/mockServiceWorker.js` instead of `/__vitest_msw__` - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6687 [<samp>(4b2ce)</samp>](vitest-dev/vitest@4b2ce07f) - Don't override the esbuild option in the browser mode - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6692 [<samp>(d131f)</samp>](vitest-dev/vitest@d131fd64) - **expect**: - Preserve prototype in `toMatchObject` diff - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6620 [<samp>(d289e)</samp>](vitest-dev/vitest@d289e7eb) - **mocker**: - Specify correct spy dependency - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(7e958)</samp>](vitest-dev/vitest@7e9584aa) - **runner**: - Ensure sequential suite overrides sequence.concurrent - by [@dsyddall](https://github.com/dsyddall) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6653 [<samp>(5e6de)</samp>](vitest-dev/vitest@5e6de274) - **vitest**: - Deprecate UserConfig in favor of ViteUserConfig - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6626 [<samp>(496bd)</samp>](vitest-dev/vitest@496bd251) - Don't hang with maxConcurrency 0 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6627 [<samp>(946d8)</samp>](vitest-dev/vitest@946d8bb1) - Deprecate old task types and node-reliant types - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6632 [<samp>(00045)</samp>](vitest-dev/vitest@000459a9) - Fix `<empty line>` logs when interleaving `console.log/error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6644 [<samp>(9ece3)</samp>](vitest-dev/vitest@9ece3952) - Show rollup error details as test error - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6686 [<samp>(47dde)</samp>](vitest-dev/vitest@47dde76f) - Always inline setup files - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6689 [<samp>(19d64)</samp>](vitest-dev/vitest@19d64e20) - Use `fast-glob` instead of `tinyglobby` in Vitest - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6688 [<samp>(70baa)</samp>](vitest-dev/vitest@70baaaa9) - **web-worker**: - Share mocker with main executor - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6623 [<samp>(fe7b8)</samp>](vitest-dev/vitest@fe7b8aee) ##### 🏎 Performance - Reuse full name in reported tasks, update generator types - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6666 [<samp>(7a0de)</samp>](vitest-dev/vitest@7a0de0a7) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.2...v2.1.3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.