Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simplify default exclude pattern #6287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Aug 6, 2024

Description

The goal of this change is to remove other testing tools from the exclude pattern reducing the maintenance burden if the new such tool is released.

One of the things that we recommend in a situation where you use different folders for different testing tools is to use config.test.dir option instead of excluding folders by name since it is more performant.

Closes #3730
Closes #3102

This is technically a breaking change so we should probably postpone it until Vitest 3.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va added this to the 3.0.0 milestone Aug 6, 2024
@sheremet-va sheremet-va changed the title feat: simplify default exclude pattern feat!: simplify default exclude pattern Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit ae88921
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66b22de51114870008069b6a
😎 Deploy Preview https://deploy-preview-6287--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclude default setting should exclude e2e tests folder
1 participant