Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): exclude bench files from coverage #5983

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

kouak
Copy link
Contributor

@kouak kouak commented Jun 27, 2024

Description

By default, benchmark files (*.bench.ts and *.benchmark.ts) are included in the coverage report.

Those should be excluded from the coverage collection.

This PR adds the relevant filenames to defaultCoverageExcludes.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio merged commit 429e1a7 into vitest-dev:main Jun 29, 2024
16 checks passed
@kouak kouak deleted the exclude-bench-files-from-coverage branch June 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants