Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flipped erase scrollback and clear screen to fix the issue with iTerm2 refresh #5978

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

kxalex
Copy link
Contributor

@kxalex kxalex commented Jun 26, 2024

Description

iTerm2 does not fully clear the scrollback history and the screen. The problem that clearing scrollback history removes the history, and leaves current page in the scrollback history. The correct sequence is clear the screen, so it's empty and then the scrollback history leaving the terminal nice and clear.

Issue: #5977

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need reproduction case to the issue first. #5977 (comment)

Test case would be great but as this is terminal specific I think it's impossible here. So reproduction case is required before we can accept this.

@AriPerkkio AriPerkkio linked an issue Jun 29, 2024 that may be closed by this pull request
6 tasks
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I can verify this fixes the issue.

Tested terminals:

  • iTerm2, this is the only terminal that could reproduce the reported bug
  • Mac's original terminal
  • VSCode terminal on Mac
  • Git Bash on virtualized windows
  • Powershell on virtualized windows
  • CMD on virtualized windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iTerm2 clear screen does not clear the screen properly
2 participants