Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): Produce valid snapshot names #5724

Merged
merged 1 commit into from
May 15, 2024

Conversation

dubzzz
Copy link
Contributor

@dubzzz dubzzz commented May 14, 2024

Description

The previous version of loupe pulled within Vitest was not properly splitting strings to produce names of snapshots. The proposed PR bumps it and adds the relevant tests.

Fixes #5681

Note: I feel the lock has changed a bit more than what I would have expected. I updated it with pnpm@8.15.8 from a GitHub Codespace. I don't really get how to properly update it if it's not the right one.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@dubzzz dubzzz mentioned this pull request May 14, 2024
6 tasks
@sheremet-va
Copy link
Member

Looks good to me! Thank you! The lint error is also on main, two PRs merged too quickly 😄

@sheremet-va sheremet-va merged commit 1ec61ce into vitest-dev:main May 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Producing unstable snapshots
2 participants