Upgrading dependencies broke the coverage report

[Aragur]

Describe the bug

Upgrading my dependencies broke the coverage file write.

> twogo-webapp@0.0.1 test:unit {{path_removed}}
> vitest "--run" "--coverage"


 RUN  v0.34.6 {{path_removed}}
      Coverage enabled with v8

 ✓ tests/unit/views/ErrorView.spec.ts (1)
 ✓ tests/unit/views/LoggedOutView.spec.ts (2)
 ✓ tests/unit/App.spec.ts (1)
 ✓ tests/unit/main.spec.ts (5)
SonarQube report written to {{path_removed}}/coverage/sonar-report.xml

 Test Files  4 passed (4)
      Tests  9 passed (9)
   Start at  10:10:20
   Duration  2.20s (transform 1.08s, setup 418ms, collect 5.63s, tests 71ms, environment 563ms, prepare 287ms)

JUNIT report written to {{path_removed}}/coverage/junit.xml

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
TypeError: The argument 'path' must be a string, Uint8Array, or URL without null bytes. Received '{{path_removed}}/coverage/lcov-report/\x00vite'
 ❯ Object.mkdirSync node:fs:1371:10
 ❯ module.exports.sync node_modules/.pnpm/make-dir@4.0.0/node_modules/make-dir/index.js:113:6
 ❯ FileWriter.writeFile node_modules/.pnpm/istanbul-lib-report@3.0.1/node_modules/istanbul-lib-report/lib/file-writer.js:184:16
 ❯ HtmlReport.onSummary node_modules/.pnpm/istanbul-reports@3.1.6/node_modules/istanbul-reports/lib/html/index.js:364:44
 ❯ LcovReport.<computed> [as onSummary] node_modules/.pnpm/istanbul-reports@3.1.6/node_modules/istanbul-reports/lib/lcov/index.js:28:23
 ❯ Visitor.value node_modules/.pnpm/istanbul-lib-report@3.0.1/node_modules/istanbul-lib-report/lib/tree.js:38:38
 ❯ ReportNode.visit node_modules/.pnpm/istanbul-lib-report@3.0.1/node_modules/istanbul-lib-report/lib/tree.js:86:21
 ❯ node_modules/.pnpm/istanbul-lib-report@3.0.1/node_modules/istanbul-lib-report/lib/tree.js:92:19
 ❯ ReportNode.visit node_modules/.pnpm/istanbul-lib-report@3.0.1/node_modules/istanbul-lib-report/lib/tree.js:91:28

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'ERR_INVALID_ARG_VALUE' }

Reproduction

https://github.com/Aragur/vitest-bug-2024_01

System Info

System:
    OS: macOS 14.3
    CPU: (10) arm64 Apple M1 Pro
    Memory: 118.75 MB / 16.00 GB
    Shell: 3.7.0 - /opt/homebrew/bin/fish
  Binaries:
    Node: 21.6.1 - /opt/homebrew/bin/node
    npm: 10.2.4 - /opt/homebrew/bin/npm
    pnpm: 8.15.1 - /opt/homebrew/bin/pnpm
    bun: 1.0.25 - /opt/homebrew/bin/bun
  Browsers:
    Chrome: 121.0.6167.85
    Safari: 17.3
  npmPackages:
    @vitejs/plugin-vue: ~5.0.3 => 5.0.3 
    @vitest/coverage-v8: ~0.34.4 => 0.34.6 
    vite: ~5.0.12 => 5.0.12 
    vitest: ~0.34.4 => 0.34.6

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[github-actions]

Hello @Aragur. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

[Aragur]

Done: https://github.com/Aragur/vitest-bug-2024_01

[AriPerkkio]

Upgrading my dependencies broke the coverage file write.

Which dependency upgrades caused this?

[Aragur]

Upgrading my dependencies broke the coverage file write.

Which dependency upgrades caused this?

Unfortunately I don't know.
Downgrading now results in the same crash.

[AriPerkkio]

In the configuration file the coverage.excludes is overwritten with custom value. You should rather extend the default values:

+import { coverageConfigDefaults } from "vitest/config";

export default defineConfig(({ mode }) => ({
    coverage: {
-      exclude: ["**/*.stories.*", "src/api"],
+      exclude: [...coverageConfigDefaults.exclude, "**/*.stories.*", "src/api"],
    },
  },
}));

Right now the configuration is overriding virtual modules' exclusion: #3794.

[Aragur]

@AriPerkkio thanks a lot. That resolved my issue.

[yevhendevbox]

@AriPerkkio thank you a lot! Literally finally fixed my problem!