Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate coverage from v8 to c8 #4366

Closed
4 tasks done
aentwist opened this issue Oct 24, 2023 · 2 comments
Closed
4 tasks done

Migrate coverage from v8 to c8 #4366

aentwist opened this issue Oct 24, 2023 · 2 comments

Comments

@aentwist
Copy link

aentwist commented Oct 24, 2023

Clear and concise description of the problem

The latest stable version of vitest 0.34.6 uses v8 for that flavor of coverage. However, from v8,

This package has been deprecated

Author message:
This tool was built when c8 package wasn't ready to be used, c8 has now more functionality and works better that this module. So you should really use c8.

Suggested solution

Go back to c8

Alternative

Suggest to install c8, but use c8 or v8 - whichever one is available (allow choice via manual installation)

Edit: after reading more I guess this is literally 2x the effort to maintain so it isn't possible

Additional context

Pull request that includes the motivation for moving from c8 to v8 #3339

Validations

@aentwist
Copy link
Author

Workaround: pin vitest version to 0.31

@sheremet-va
Copy link
Member

sheremet-va commented Oct 24, 2023

Vitest never used that package. To use v8 coverage, install @vitest/coverage-v8. v8 is the name of the engine, not the tool. Vitest uses native inspector to collect native coverage in that case.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants