v0.34.0 "URL is not defined" failure when using isolate: false

[EvHaus]

Describe the bug

After upgrading from vitest version 0.33.0 to 0.34.0 I'm seeing this failure in any tests which rely on the URL global:

ReferenceError: URL is not defined

I'm guessing this is related to the change in:

• fix: don't overwrite Node.js URL global #3828

What's interesting is that my failure only occurs when isolate: false is used. Setting isolate: true makes the problem go away. The error also doesn't happen when focusing on specific tests in watch mode. It only shows up when running my entire test suite.

Rolling back to 0.33.0 fixes the issue.

Reproduction

I haven't been able to reproduce via StackBlitz in a minimal scenario yet, so it's possible it's caused by some interplay between other tests, or perhaps the order in which tests run?

Any advice on what the issue might be? Maybe I can give it another try.

System Info

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 79.16 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.1 - ~/.nvm/versions/node/v20.5.1/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.0 - ~/.nvm/versions/node/v20.5.1/bin/npm
  Browsers:
    Chrome: 115.0.5790.170
    Chrome Canary: 118.0.5956.0
    Edge: 114.0.1823.55
    Firefox: 116.0.2
    Safari: 16.5.2

Used Package Manager

yarn

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[kjetilod]

I also see this error with Node 18.6.0, but upgrading to 18.17.1 fixes it.

[kjetilod]

I also see this error with Node 18.6.0, but upgrading to 18.17.1 fixes it.

After some more testing, I still get this error on 18.17.1 some times. Seems pretty random from run to run if tests run ok or fail with this error.