Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip coverage when spec runner bails #3388

Closed
4 tasks done
capaj opened this issue May 17, 2023 · 1 comment · Fixed by #3453
Closed
4 tasks done

skip coverage when spec runner bails #3388

capaj opened this issue May 17, 2023 · 1 comment · Fixed by #3453
Labels
feat: coverage Issues and PRs related to the coverage feature

Comments

@capaj
Copy link

capaj commented May 17, 2023 •
edited
Loading

Clear and concise description of the problem

When there is a failure and --bail is set to any value the coverage gets generated and in our project always fails to meet thresholds.

Suggested solution

do not bother with coverage when spec runner bailed

Alternative

No response

Additional context

No response

Validations
@AriPerkkio
Copy link
Member

Similar as #2908

@AriPerkkio AriPerkkio added the feat: coverage Issues and PRs related to the coverage feature label May 17, 2023
@AriPerkkio AriPerkkio mentioned this issue May 26, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feat: coverage Issues and PRs related to the coverage feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(coverage): add reportOnFailure option AriPerkkio/vitest
2 participants
@capaj @AriPerkkio