Skip to content

Commit 3ae5514

Browse files
authored
test: re-enable skipped test for Vite 6 (#7558)
1 parent 1a8b433 commit 3ae5514

File tree

2 files changed

+23
-26
lines changed

2 files changed

+23
-26
lines changed

test/cli/test/__snapshots__/stacktraces.test.ts.snap

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
22

3-
exports[`stacktrace filtering > filters stacktraces > stacktrace-filtering 1`] = `
3+
exports[`stacktrace filtering > filters stacktraces 1`] = `
44
"
55
⎯⎯ Failed Tests 1 ⎯⎯
66
@@ -45,27 +45,27 @@ Error: Something truly horrible has happened!
4545
"
4646
`;
4747

48-
exports[`stacktrace should print error frame source file correctly > error-in-deps > error-in-deps 1`] = `
48+
exports[`stacktrace should print error frame source file correctly > error-in-deps 1`] = `
4949
"
5050
⎯⎯ Failed Tests 1 ⎯⎯
5151
5252
FAIL error-in-deps.test.js > error in deps
5353
ReferenceError: bar is not defined
54-
Module.add foo.js:3:3
54+
❯ add foo.js:3:3
5555
1| export function add() {
5656
2| // eslint-disable-next-line no-undef
5757
3| return bar()
5858
| ^
5959
4| }
6060
5|
61-
❯ error-in-deps.test.js:5:3
61+
❯ error-in-deps.test.js:5:6
6262
6363
⎯⎯[1/1]⎯
6464
6565
"
6666
`;
6767

68-
exports[`stacktraces should pick error frame if present > frame.spec.imba > frame.spec.imba 1`] = `
68+
exports[`stacktraces should pick error frame if present > frame.spec.imba 1`] = `
6969
" FAIL frame.spec.imba [ frame.spec.imba ]
7070
imba-parser error: Unexpected 'CALL_END'
7171
4 | test("1+1") do
@@ -76,7 +76,7 @@ imba-parser error: Unexpected 'CALL_END'
7676
"
7777
`;
7878

79-
exports[`stacktraces should respect sourcemaps > add.test.ts > add.test.ts 1`] = `
79+
exports[`stacktraces should respect sourcemaps > add.test.ts 1`] = `
8080
" ❯ add.test.ts:12:24
8181
10|
8282
11| it('add', () => {
@@ -87,7 +87,7 @@ exports[`stacktraces should respect sourcemaps > add.test.ts > add.test.ts 1`] =
8787
"
8888
`;
8989
90-
exports[`stacktraces should respect sourcemaps > add-in-imba.test.imba > add-in-imba.test.imba 1`] = `
90+
exports[`stacktraces should respect sourcemaps > add-in-imba.test.imba 1`] = `
9191
" ❯ add-in-imba.test.imba:8:17
9292
6| it "add", do
9393
7| expect(add()).toBe 0
@@ -98,7 +98,7 @@ exports[`stacktraces should respect sourcemaps > add-in-imba.test.imba > add-in-
9898
"
9999
`;
100100
101-
exports[`stacktraces should respect sourcemaps > add-in-js.test.js > add-in-js.test.js 1`] = `
101+
exports[`stacktraces should respect sourcemaps > add-in-js.test.js 1`] = `
102102
" ❯ add-in-js.test.js:6:17
103103
4|
104104
5| it('add', () => {
@@ -109,15 +109,15 @@ exports[`stacktraces should respect sourcemaps > add-in-js.test.js > add-in-js.t
109109
"
110110
`;
111111
112-
exports[`stacktraces should respect sourcemaps > error-in-deps.test.js > error-in-deps.test.js 1`] = `
113-
" ❯ error-in-deps.test.js:5:3
112+
exports[`stacktraces should respect sourcemaps > error-in-deps.test.js 1`] = `
113+
" ❯ error-in-deps.test.js:5:6
114114
115115
⎯⎯[1/1]⎯
116116
117117
"
118118
`;
119119
120-
exports[`stacktraces should respect sourcemaps > error-with-stack.test.js > error-with-stack.test.js 1`] = `
120+
exports[`stacktraces should respect sourcemaps > error-with-stack.test.js 1`] = `
121121
" ❯ d error-with-stack.test.js:20:9
122122
18|
123123
19| function d() {
@@ -128,7 +128,7 @@ exports[`stacktraces should respect sourcemaps > error-with-stack.test.js > erro
128128
❯ c error-with-stack.test.js:16:3"
129129
`;
130130
131-
exports[`stacktraces should respect sourcemaps > mocked-global.test.js > mocked-global.test.js 1`] = `
131+
exports[`stacktraces should respect sourcemaps > mocked-global.test.js 1`] = `
132132
" ❯ mocked-global.test.js:6:13
133133
4|
134134
5| test('failed', () => {
@@ -139,7 +139,7 @@ exports[`stacktraces should respect sourcemaps > mocked-global.test.js > mocked-
139139
"
140140
`;
141141
142-
exports[`stacktraces should respect sourcemaps > mocked-imported.test.js > mocked-imported.test.js 1`] = `
142+
exports[`stacktraces should respect sourcemaps > mocked-imported.test.js 1`] = `
143143
" ❯ mocked-imported.test.js:6:13
144144
4|
145145
5| test('failed', () => {
@@ -150,7 +150,7 @@ exports[`stacktraces should respect sourcemaps > mocked-imported.test.js > mocke
150150
"
151151
`;
152152
153-
exports[`stacktraces should respect sourcemaps > mocked-imported.test.ts > mocked-imported.test.ts 1`] = `
153+
exports[`stacktraces should respect sourcemaps > mocked-imported.test.ts 1`] = `
154154
" ❯ mocked-imported.test.ts:6:13
155155
4|
156156
5| test('failed', () => {
@@ -161,18 +161,18 @@ exports[`stacktraces should respect sourcemaps > mocked-imported.test.ts > mocke
161161
"
162162
`;
163163
164-
exports[`stacktraces should respect sourcemaps > require-assertions.test.js > require-assertions.test.js 1`] = `
165-
" ❯ require-assertions.test.js:3:1
164+
exports[`stacktraces should respect sourcemaps > require-assertions.test.js 1`] = `
165+
" ❯ require-assertions.test.js:3:5
166166
1| import { test } from 'vitest'
167167
2|
168168
3| test('assertion is not called', () => {
169-
| ^
169+
| ^
170170
4| // no expect
171171
5| })
172172
"
173173
`;
174174
175-
exports[`stacktraces should respect sourcemaps > reset-modules.test.ts > reset-modules.test.ts 1`] = `
175+
exports[`stacktraces should respect sourcemaps > reset-modules.test.ts 1`] = `
176176
" ❯ reset-modules.test.ts:16:26
177177
14| expect(2 + 1).eq(3)
178178
15| assert.equal(Math.sqrt(4), 2)

test/cli/test/stacktraces.test.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
import { resolve } from 'pathe'
22
import { glob } from 'tinyglobby'
3-
import { version as viteVersion } from 'vite'
4-
import { describe, expect, it as vitestIt } from 'vitest'
3+
import { describe, expect, it } from 'vitest'
54
import { runVitest } from '../../test-utils'
65

76
const [major] = process.version.slice(1).split('.').map(num => Number(num))
87

9-
const it = viteVersion[0] >= '6' ? (vitestIt.skip as typeof vitestIt) : vitestIt
10-
118
// To prevent the warning coming up in snapshots
129
process.setMaxListeners(20)
1310

@@ -23,7 +20,7 @@ describe('stacktraces should respect sourcemaps', async () => {
2320
const lines = String(stderr).split(/\n/g)
2421
const index = lines.findIndex(val => val.includes(`${file}:`))
2522
const msg = lines.slice(index, index + 8).join('\n')
26-
expect(removeLines(msg)).toMatchSnapshot(file)
23+
expect(removeLines(msg)).toMatchSnapshot()
2724
})
2825
}
2926
})
@@ -40,7 +37,7 @@ describe('stacktraces should pick error frame if present', async () => {
4037
const lines = String(stderr).split(/\n/g)
4138
const index = lines.findIndex(val => val.includes('FAIL'))
4239
const msg = lines.slice(index, index + 8).join('\n')
43-
expect(msg).toMatchSnapshot(file)
40+
expect(msg).toMatchSnapshot()
4441
})
4542
}
4643
})
@@ -53,7 +50,7 @@ describe('stacktrace should print error frame source file correctly', async () =
5350
const { stderr } = await runVitest({ root }, [testFile])
5451

5552
// expect to print framestack of foo.js
56-
expect(removeLines(stderr)).toMatchSnapshot('error-in-deps')
53+
expect(removeLines(stderr)).toMatchSnapshot()
5754
})
5855
})
5956

@@ -67,7 +64,7 @@ describe('stacktrace filtering', async () => {
6764
onStackTrace: (_error, { method }) => method !== 'b',
6865
}, [testFile])
6966

70-
expect(removeLines(stderr)).toMatchSnapshot('stacktrace-filtering')
67+
expect(removeLines(stderr)).toMatchSnapshot()
7168
})
7269
})
7370

0 commit comments

Comments
 (0)