fix(vitest): correctly filter changed files when Vitest workspace is used (#4693)

sheremet-va · web-flow · commit 3413518b3a33 · 2023-12-08T18:36:41.000+01:00
diff --git a/packages/vitest/src/node/core.ts b/packages/vitest/src/node/core.ts
@@ -378,7 +378,7 @@ export class Vitest {
         return
       const dependencies = [...transformed.deps || [], ...transformed.dynamicDeps || []]
       await Promise.all(dependencies.map(async (dep) => {
-        const path = await this.server.pluginContainer.resolveId(dep, filepath, { ssr: true })
+        const path = await project.server.pluginContainer.resolveId(dep, filepath, { ssr: true })
         const fsPath = path && !path.external && path.id.split('?')[0]
         if (fsPath && !fsPath.includes('node_modules') && !deps.has(fsPath) && existsSync(fsPath)) {
           deps.add(fsPath)
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/changed/fixtures/related/not-related.test.ts b/test/changed/fixtures/related/not-related.test.ts
@@ -1,5 +1,5 @@
 import { expect, test } from 'vitest'
-import { B } from '../src/sourceB'
+import { B } from './src/sourceB'
 
 test('shouldn\'t run', () => {
   expect(B).toBe('B')
diff --git a/test/changed/fixtures/related/related.test.ts b/test/changed/fixtures/related/related.test.ts
@@ -1,7 +1,7 @@
 import { access } from 'node:fs'
 import { sep } from 'pathe'
 import { expect, test } from 'vitest'
-import { A } from '../src/sourceA'
+import { A } from './src/sourceA'
 
 test('A equals A', () => {
   expect(A).toBe('A')
diff --git a/test/changed/fixtures/related/src/sourceA.ts b/test/changed/fixtures/related/src/sourceA.ts
diff --git a/test/changed/fixtures/related/src/sourceB.ts b/test/changed/fixtures/related/src/sourceB.ts
diff --git a/test/changed/fixtures/related/vitest.config.js b/test/changed/fixtures/related/vitest.config.js
@@ -0,0 +1 @@
+export default {}
diff --git a/test/changed/fixtures/workspace/package.json b/test/changed/fixtures/workspace/package.json
@@ -0,0 +1,3 @@
+{
+  "type": "commonjs"
+}
diff --git a/test/changed/fixtures/workspace/packages/packageA/index.js b/test/changed/fixtures/workspace/packages/packageA/index.js
@@ -0,0 +1,3 @@
+export default function getLetter() {
+  return 'c';
+}
diff --git a/test/changed/fixtures/workspace/packages/packageA/index.test.js b/test/changed/fixtures/workspace/packages/packageA/index.test.js
@@ -0,0 +1,8 @@
+import { describe, expect, it } from 'vitest';
+import getLetter from './index';
+describe('getLetter', () => {
+  const result = getLetter();
+  it('should return c', () => {
+    expect(result).toBe('c');
+  });
+});
diff --git a/test/changed/fixtures/workspace/packages/packageA/vitest.config.mjs b/test/changed/fixtures/workspace/packages/packageA/vitest.config.mjs
@@ -0,0 +1,3 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({});
diff --git a/test/changed/fixtures/workspace/packages/packageB/index.js b/test/changed/fixtures/workspace/packages/packageB/index.js
@@ -0,0 +1,3 @@
+export default function getNumber() {
+  return 3;
+}
diff --git a/test/changed/fixtures/workspace/packages/packageB/index.test.js b/test/changed/fixtures/workspace/packages/packageB/index.test.js
@@ -0,0 +1,8 @@
+import { describe, expect, it } from 'vitest';
+import getNumber from './index';
+describe('getNumber', () => {
+  const result = getNumber();
+  it('should return 3', () => {
+    expect(result).toBe(3);
+  });
+});
diff --git a/test/changed/fixtures/workspace/packages/packageB/vitest.config.mjs b/test/changed/fixtures/workspace/packages/packageB/vitest.config.mjs
@@ -0,0 +1,3 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({});
diff --git a/test/changed/fixtures/workspace/vitest.config.mjs b/test/changed/fixtures/workspace/vitest.config.mjs
@@ -0,0 +1 @@
+export default {}
diff --git a/test/changed/fixtures/workspace/vitest.workspace.js b/test/changed/fixtures/workspace/vitest.workspace.js
@@ -0,0 +1,3 @@
+export default [
+  "packages/*/vitest.config.js",
+];
diff --git a/test/changed/package.json b/test/changed/package.json
@@ -0,0 +1,11 @@
+{
+  "name": "@vitest/test-changed",
+  "type": "module",
+  "private": true,
+  "scripts": {
+    "test": "vitest"
+  },
+  "devDependencies": {
+    "vitest": "workspace:*"
+  }
+}
diff --git a/test/changed/tests/forceRerunTrigger.test.ts b/test/changed/tests/forceRerunTrigger.test.ts
@@ -1,31 +1,36 @@
 import { unlink, writeFile } from 'node:fs'
+import { join } from 'node:path'
 import { beforeEach, describe, expect, it } from 'vitest'
 
 import { runVitest } from '../../test-utils'
 
-async function run() {
-  return runVitest({
-    include: ['tests/related.test.ts'],
-    forceRerunTriggers: ['**/rerun.temp/**'],
-    changed: true,
-  })
-}
-
-const fileName = 'rerun.temp'
+const fileName = 'fixtures/related/rerun.temp'
 
 describe('forceRerunTrigger', () => {
+  async function run() {
+    return runVitest({
+      root: join(process.cwd(), 'fixtures/related'),
+      include: ['related.test.ts'],
+      forceRerunTriggers: ['**/rerun.temp/**'],
+      changed: true,
+    })
+  }
+
   beforeEach(async () => {
     unlink(fileName, () => {})
   })
 
   it('should run the whole test suite if file exists', async () => {
     writeFile(fileName, '', () => {})
-    const { stdout } = await run()
+    const { stdout, stderr } = await run()
+    expect(stderr).toBe('')
     expect(stdout).toContain('1 passed')
-  }, 60_000)
+    expect(stdout).toContain('related.test.ts')
+    expect(stdout).not.toContain('not-related.test.ts')
+  })
 
   it('should run no tests if file does not exist', async () => {
     const { stdout } = await run()
     expect(stdout).toContain('No test files found, exiting with code 0')
-  }, 60_000)
+  })
 })
diff --git a/test/changed/tests/related.test.ts b/test/changed/tests/related.test.ts
@@ -0,0 +1,12 @@
+import { join } from 'node:path'
+import { expect, it } from 'vitest'
+
+import { runVitestCli } from '../../test-utils'
+
+it('related correctly runs only related tests', async () => {
+  const { stdout, stderr } = await runVitestCli('related', join(process.cwd(), 'fixtures/related/src/sourceA.ts'), '--root', join(process.cwd(), './fixtures/related'), '--globals', '--no-watch')
+  expect(stderr).toBe('')
+  expect(stdout).toContain('1 passed')
+  expect(stdout).toContain('related.test.ts')
+  expect(stdout).not.toContain('not-related.test.ts')
+})
diff --git a/test/changed/tests/workspaceRelated.test.ts b/test/changed/tests/workspaceRelated.test.ts
@@ -0,0 +1,19 @@
+import { join } from 'node:path'
+import { expect, it } from 'vitest'
+
+import { editFile, resolvePath, runVitestCli } from '../../test-utils'
+
+it('doesn\'t run any test in a workspace because there are no changes', async () => {
+  const { stdout } = await runVitestCli('--root', join(process.cwd(), './fixtures/workspace'), '--no-watch', '--changed')
+  expect(stdout).toContain('No test files found, exiting with code 0')
+})
+
+// Fixes #4674
+it('related correctly runs only related tests inside a workspace', async () => {
+  editFile(resolvePath(import.meta.url, '../fixtures/workspace/packages/packageA/index.js'), content => `${content}\n`)
+  const { stdout, stderr } = await runVitestCli('--root', join(process.cwd(), './fixtures/workspace'), '--no-watch', '--changed')
+  expect(stderr).toBe('')
+  expect(stdout).toContain('1 passed')
+  expect(stdout).toContain('packageA')
+  expect(stdout).not.toContain('packageB')
+})
diff --git a/test/changed/vitest.config.js b/test/changed/vitest.config.js
@@ -2,7 +2,8 @@ import { defineConfig } from 'vitest/config'
 
 export default defineConfig({
   test: {
-    include: ['tests/related.test.ts'],
-    forceRerunTriggers: ['**/rerun.temp/**'],
+    include: ['tests/**/*.test.ts'],
+    testTimeout: 60_000,
+    hookTimeout: 60_000,
   },
 })
diff --git a/test/related/package.json b/test/related/package.json

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default function getLetter() {`
	`2`	`+ return 'c';`
	`3`	`+}`