Proposal to fix "pnpm tsc" #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veritem
requested changes
Jun 16, 2025
This was referenced Aug 26, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the
pnpm tscshould succeed and can be activated in CI, if suits. I hope I didn't break any other things, but you'll find my way below:So I went on reading into https://typescript-eslint.io/developers/custom-rules and changed
createEslintRuleaccordingly. Then went on to https://github.com/typescript-eslint/examples/blob/main/packages/eslint-plugin-example-typed-linting/src/index.ts and changed return types in plugin accordingly.Rest of the tsc issues (in tests) where just "hidden" due to tsc wasn't checked in CI - fixed them accordingly.
Hope this makes the changes understandable, I am happy to hear, also if I missed something.