refactor: Enforce no-prototype-builtins as an Error (#815)

y-hsgw · web-flow · commit f76e700a545f · 2025-11-05T08:42:24.000-05:00
* docs: remove docs

* fix: use Object.prototype.hasOwnProperty

* chore: tidy eslint configs

* fix: typecheck
diff --git a/docs/rules/assertion-type.md b/docs/rules/assertion-type.md
diff --git a/docs/rules/max-expect.md b/docs/rules/max-expect.md
diff --git a/eslint-remote-tester.config.ts b/eslint-remote-tester.config.ts
@@ -4,9 +4,7 @@ import {
   getPathIgnorePattern,
   getRepositories,
 } from 'eslint-remote-tester-repositories'
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore available once package is built
-import vitest from '@vitest/eslint-plugin'
+import vitest from './src'
 
 export default {
   repositories: getRepositories(),
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -37,9 +37,13 @@ export default defineConfig(
       'eslint-plugin/require-meta-default-options': 'warn',
       'eslint-plugin/require-meta-schema-description': 'warn',
       'eslint-plugin/no-meta-schema-default': 'warn',
-      'no-prototype-builtins': 'warn',
       'no-unsafe-optional-chaining': 'warn',
     },
   },
+  {
+    linterOptions: {
+      reportUnusedDisableDirectives: true,
+    },
+  },
   eslintConfigPrettier,
 )
diff --git a/src/rules/no-restricted-matchers.ts b/src/rules/no-restricted-matchers.ts
@@ -7,7 +7,10 @@ type MESSAGE_IDS = 'restrictedChain' | 'restrictedChainWithMessage'
 type Options = Record<string, string | null>[]
 
 const isChainRestricted = (chain: string, restriction: string): boolean => {
-  if (ModifierName.hasOwnProperty(restriction) || restriction.endsWith('.not'))
+  if (
+    Object.prototype.hasOwnProperty.call(ModifierName, restriction) ||
+    restriction.endsWith('.not')
+  )
     return chain.startsWith(restriction)
 
   return chain === restriction
diff --git a/src/rules/prefer-comparison-matcher.ts b/src/rules/prefer-comparison-matcher.ts
@@ -91,7 +91,10 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         if (
           comparison?.type !== AST_NODE_TYPES.BinaryExpression ||
           isComparingToString(comparison) ||
-          !EqualityMatcher.hasOwnProperty(getAccessorValue(matcher)) ||
+          !Object.prototype.hasOwnProperty.call(
+            EqualityMatcher,
+            getAccessorValue(matcher),
+          ) ||
           !isBooleanLiteral(matcherArg)
         )
           return
diff --git a/src/rules/prefer-equality-matcher.ts b/src/rules/prefer-equality-matcher.ts
@@ -50,7 +50,10 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         if (
           comparison?.type !== AST_NODE_TYPES.BinaryExpression ||
           (comparison.operator !== '===' && comparison.operator !== '!==') ||
-          !EqualityMatcher.hasOwnProperty(getAccessorValue(matcher)) ||
+          !Object.prototype.hasOwnProperty.call(
+            EqualityMatcher,
+            getAccessorValue(matcher),
+          ) ||
           !isBooleanLiteral(matcherArg)
         )
           return
diff --git a/src/rules/prefer-to-be-falsy.ts b/src/rules/prefer-to-be-falsy.ts
@@ -48,7 +48,10 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         if (
           vitestFnCall.args.length === 1 &&
           isFalseLiteral(getFirstMatcherArg(vitestFnCall)) &&
-          EqualityMatcher.hasOwnProperty(getAccessorValue(vitestFnCall.matcher))
+          Object.prototype.hasOwnProperty.call(
+            EqualityMatcher,
+            getAccessorValue(vitestFnCall.matcher),
+          )
         ) {
           context.report({
             node: vitestFnCall.matcher,
diff --git a/src/rules/prefer-to-be-truthy.ts b/src/rules/prefer-to-be-truthy.ts
@@ -48,7 +48,10 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         if (
           vitestFnCall.args.length === 1 &&
           isTrueLiteral(getFirstMatcherArg(vitestFnCall)) &&
-          EqualityMatcher.hasOwnProperty(getAccessorValue(vitestFnCall.matcher))
+          Object.prototype.hasOwnProperty.call(
+            EqualityMatcher,
+            getAccessorValue(vitestFnCall.matcher),
+          )
         ) {
           context.report({
             node: vitestFnCall.matcher,
diff --git a/src/rules/prefer-to-be.ts b/src/rules/prefer-to-be.ts
@@ -138,7 +138,7 @@ export default createEslintRule<[], MessageId>({
         }
 
         if (
-          !EqualityMatcher.hasOwnProperty(matcherName) ||
+          !Object.prototype.hasOwnProperty.call(EqualityMatcher, matcherName) ||
           vitestFnCall.args.length === 0
         )
           return
diff --git a/src/rules/prefer-to-contain.ts b/src/rules/prefer-to-contain.ts
@@ -70,7 +70,10 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         if (
           !includesCall ||
           matcherArg.type === AST_NODE_TYPES.SpreadElement ||
-          !EqualityMatcher.hasOwnProperty(getAccessorValue(matcher)) ||
+          !Object.prototype.hasOwnProperty.call(
+            EqualityMatcher,
+            getAccessorValue(matcher),
+          ) ||
           !isBooleanLiteral(matcherArg) ||
           !isFixableIncludesCallExpression(includesCall)
         )
diff --git a/src/rules/prefer-to-have-length.ts b/src/rules/prefer-to-have-length.ts
@@ -41,7 +41,10 @@ export default createEslintRule<Options, MESSAGE_IDS>({
         const { matcher } = vitestFnCall
 
         if (
-          !EqualityMatcher.hasOwnProperty(getAccessorValue(matcher)) ||
+          !Object.prototype.hasOwnProperty.call(
+            EqualityMatcher,
+            getAccessorValue(matcher),
+          ) ||
           argument?.type !== AST_NODE_TYPES.MemberExpression ||
           !isSupportedAccessor(argument.property, 'length')
         )
diff --git a/src/rules/valid-expect.ts b/src/rules/valid-expect.ts
@@ -253,7 +253,10 @@ export default createEslintRule<
             context.report({
               messageId:
                 isSupportedAccessor(reportingNode) &&
-                ModifierName.hasOwnProperty(getAccessorValue(reportingNode))
+                Object.prototype.hasOwnProperty.call(
+                  ModifierName,
+                  getAccessorValue(reportingNode),
+                )
                   ? 'matcherNotFound'
                   : 'matcherNotCalled',
               node: reportingNode,
diff --git a/src/utils/msc.ts b/src/utils/msc.ts
@@ -26,7 +26,10 @@ export const isBooleanEqualityMatcher = (
 
   const arg = getFirstMatcherArg(expectFnCall)
 
-  return EqualityMatcher.hasOwnProperty(matcherName) && isBooleanLiteral(arg)
+  return (
+    Object.prototype.hasOwnProperty.call(EqualityMatcher, matcherName) &&
+    isBooleanLiteral(arg)
+  )
 }
 
 export const isInstanceOfBinaryExpression = (
diff --git a/src/utils/parse-vitest-fn-call.ts b/src/utils/parse-vitest-fn-call.ts
@@ -131,11 +131,12 @@ const determineVitestFnType = (name: string): VitestFnType => {
 
   if (name === 'vitest') return 'vitest'
 
-  if (DescribeAlias.hasOwnProperty(name)) return 'describe'
+  if (Object.prototype.hasOwnProperty.call(DescribeAlias, name))
+    return 'describe'
 
-  if (TestCaseName.hasOwnProperty(name)) return 'test'
+  if (Object.prototype.hasOwnProperty.call(TestCaseName, name)) return 'test'
 
-  if (HookName.hasOwnProperty(name)) return 'hook'
+  if (Object.prototype.hasOwnProperty.call(HookName, name)) return 'hook'
 
   return 'unknown'
 }
@@ -164,7 +165,8 @@ const findModifiersAndMatcher = (
 
     if (modifiers.length === 0) {
       // the first modifier can be any of the three modifiers
-      if (!ModifierName.hasOwnProperty(name)) return 'modifier-unknown'
+      if (!Object.prototype.hasOwnProperty.call(ModifierName, name))
+        return 'modifier-unknown'
     } else if (modifiers.length === 1) {
       // the second modifier can only either be "not" or "have"
       if (name !== ModifierName.not && name != ModifierName.have)
@@ -397,7 +399,7 @@ const isAncestorTestCaseCall = ({ parent }: TSESTree.Node) => {
   return (
     parent?.type === AST_NODE_TYPES.CallExpression &&
     parent.callee.type === AST_NODE_TYPES.Identifier &&
-    TestCaseName.hasOwnProperty(parent.callee.name)
+    Object.prototype.hasOwnProperty.call(TestCaseName, parent.callee.name)
   )
 }
 
@@ -433,7 +435,7 @@ export const resolveScope = (
       if (
         def.node.type === AST_NODE_TYPES.VariableDeclarator &&
         def.node.id.type === AST_NODE_TYPES.Identifier &&
-        TestCaseName.hasOwnProperty(def.node.id.name) &&
+        Object.prototype.hasOwnProperty.call(TestCaseName, def.node.id.name) &&
         def.node.init?.type === AST_NODE_TYPES.CallExpression &&
         def.node.init.callee.type === AST_NODE_TYPES.MemberExpression &&
         isIdentifier(def.node.init.callee.property, 'extend')

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ export default createEslintRule<[], MessageId>({`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if (`
`141`		`- !EqualityMatcher.hasOwnProperty(matcherName) \|\|`
	`141`	`+ !Object.prototype.hasOwnProperty.call(EqualityMatcher, matcherName) \|\|`
`142`	`142`	`vitestFnCall.args.length === 0`
`143`	`143`	`)`
`144`	`144`	`return`