fix(no-focused-tests): not all chainable APIs are reported (#878)

Closes #877

Author: StyleShit

src/rules/no-focused-tests.ts

@@ -1,5 +1,5 @@
-import { TSESTree } from '@typescript-eslint/utils'
-import { createEslintRule } from '../utils'
+import { createEslintRule, getAccessorValue } from '../utils'
+import { parseVitestFnCall } from '../utils/parse-vitest-fn-call'
 
 export type MessageIds = 'noFocusedTests'
 const RULE_NAME = 'no-focused-tests'
@@ -9,16 +9,6 @@ export type Options = [
   }>,
 ]
 
-const isTestOrDescribe = (node: TSESTree.Expression) => {
-  return (
-    node.type === 'Identifier' && ['it', 'test', 'describe'].includes(node.name)
-  )
-}
-
-const isOnly = (node: TSESTree.Expression | TSESTree.PrivateIdentifier) => {
-  return node.type === 'Identifier' && node.name === 'only'
-}
-
 export default createEslintRule<Options, MessageIds>({
   name: RULE_NAME,
   meta: {
@@ -49,78 +39,30 @@ export default createEslintRule<Options, MessageIds>({
     const fixable = options[0].fixable!
 
     return {
-      ExpressionStatement(node) {
-        if (node.expression.type === 'CallExpression') {
-          const { callee } = node.expression
-          if (
-            callee.type === 'MemberExpression' &&
-            isTestOrDescribe(callee.object) &&
-            isOnly(callee.property)
-          ) {
-            context.report({
-              node: callee.property,
-              messageId: 'noFocusedTests',
-              fix: (fixer) =>
-                fixable
-                  ? fixer.removeRange([
-                      callee.property.range[0] - 1,
-                      callee.property.range[1],
-                    ])
-                  : null,
-            })
-          }
-
-          if (callee.type === 'TaggedTemplateExpression') {
-            const tagCall =
-              callee.tag.type === 'MemberExpression' ? callee.tag.object : null
-            if (!tagCall) return
+      CallExpression(node) {
+        const vitestFnCall = parseVitestFnCall(node, context)
 
-            if (
-              tagCall.type === 'MemberExpression' &&
-              isTestOrDescribe(tagCall.object) &&
-              isOnly(tagCall.property)
-            ) {
-              context.report({
-                node: tagCall.property,
-                messageId: 'noFocusedTests',
-                fix: (fixer) =>
-                  fixable
-                    ? fixer.removeRange([
-                        tagCall.property.range[0] - 1,
-                        tagCall.property.range[1],
-                      ])
-                    : null,
-              })
-            }
-          }
+        if (!vitestFnCall) {
+          return
         }
-      },
-      CallExpression(node) {
-        if (node.callee.type === 'CallExpression') {
-          const { callee } = node.callee
 
-          if (
-            callee.type === 'MemberExpression' &&
-            callee.object.type === 'MemberExpression' &&
-            isTestOrDescribe(callee.object.object) &&
-            isOnly(callee.object.property) &&
-            callee.property.type === 'Identifier' &&
-            callee.property.name === 'each'
-          ) {
-            const onlyCallee = callee.object.property
+        const isTestOrDescribe = ['it', 'test', 'describe'].includes(
+          vitestFnCall.name,
+        )
+
+        const onlyNode = vitestFnCall.members.find(
+          (m) => getAccessorValue(m) === 'only',
+        )
 
-            context.report({
-              node: callee.object.property,
-              messageId: 'noFocusedTests',
-              fix: (fixer) =>
-                fixable
-                  ? fixer.removeRange([
-                      onlyCallee.range[0] - 1,
-                      onlyCallee.range[1],
-                    ])
-                  : null,
-            })
-          }
+        if (isTestOrDescribe && onlyNode) {
+          context.report({
+            node: onlyNode,
+            messageId: 'noFocusedTests',
+            fix: (fixer) =>
+              fixable
+                ? fixer.removeRange([onlyNode.range[0] - 1, onlyNode.range[1]])
+                : null,
+          })
         }
       },
     }

tests/no-focused-tests.test.ts

@@ -2,7 +2,19 @@ import rule from '../src/rules/no-focused-tests'
 import { ruleTester } from './ruleTester'
 
 ruleTester.run(rule.name, rule, {
-  valid: ['it("test", () => {});', 'describe("test group", () => {});'],
+  valid: [
+    'it("test", () => {});',
+    'it.each([])("test", () => {});',
+    'it.for([])("test", () => {});',
+
+    'test("test", () => {});',
+    'test.each([])("test", () => {});',
+    'test.for([])("test", () => {});',
+
+    'describe("test group", () => {});',
+    'describe.each([])("test group", () => {});',
+    'describe.for([])("test group", () => {});',
+  ],
   invalid: [
     {
       options: [
@@ -72,6 +84,57 @@ ruleTester.run(rule.name, rule, {
         },
       ],
     },
+    {
+      options: [
+        {
+          fixable: false,
+        },
+      ],
+      code: 'it.only.for([])("test", () => {});',
+      errors: [
+        {
+          column: 4,
+          endColumn: 8,
+          endLine: 1,
+          line: 1,
+          messageId: 'noFocusedTests',
+        },
+      ],
+    },
+    {
+      options: [
+        {
+          fixable: false,
+        },
+      ],
+      code: 'describe.only.each([])("test", () => {});',
+      errors: [
+        {
+          column: 10,
+          endColumn: 14,
+          endLine: 1,
+          line: 1,
+          messageId: 'noFocusedTests',
+        },
+      ],
+    },
+    {
+      options: [
+        {
+          fixable: false,
+        },
+      ],
+      code: 'describe.only.for([])("test", () => {});',
+      errors: [
+        {
+          column: 10,
+          endColumn: 14,
+          endLine: 1,
+          line: 1,
+          messageId: 'noFocusedTests',
+        },
+      ],
+    },
     {
       options: [
         {
@@ -164,6 +227,45 @@ ruleTester.run(rule.name, rule, {
       ],
       output: 'it.each([])("test", () => {});',
     },
+    {
+      code: 'it.only.for([])("test", () => {});',
+      output: 'it.for([])("test", () => {});',
+      errors: [
+        {
+          column: 4,
+          endColumn: 8,
+          endLine: 1,
+          line: 1,
+          messageId: 'noFocusedTests',
+        },
+      ],
+    },
+    {
+      code: 'describe.only.each([])("test", () => {});',
+      output: 'describe.each([])("test", () => {});',
+      errors: [
+        {
+          column: 10,
+          endColumn: 14,
+          endLine: 1,
+          line: 1,
+          messageId: 'noFocusedTests',
+        },
+      ],
+    },
+    {
+      code: 'describe.only.for([])("test", () => {});',
+      output: 'describe.for([])("test", () => {});',
+      errors: [
+        {
+          column: 10,
+          endColumn: 14,
+          endLine: 1,
+          line: 1,
+          messageId: 'noFocusedTests',
+        },
+      ],
+    },
     {
       code: 'test.only.each``("test", () => {});',
       errors: [