Skip to content

Commit 089732f

Browse files
authored
fix(valid-title): Refine the reportEmptyTitle message (#941)
* fix: Refine the reportEmptyTitle message Signed-off-by: ysknsid25 <kengo071225@gmail.com> * fix: Refine the reportEmptyTitle message Signed-off-by: ysknsid25 <kengo071225@gmail.com> --------- Signed-off-by: ysknsid25 <kengo071225@gmail.com>
1 parent 96f6bfd commit 089732f

2 files changed

Lines changed: 21 additions & 4 deletions

File tree

src/rules/valid-title.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,9 @@ export default createEslintRule<Options, MESSAGE_IDS>({
239239
functionName:
240240
vitestFnCall.type === 'describe'
241241
? DescribeAlias.describe
242-
: TestCaseName.test,
242+
: trimFXPrefix(vitestFnCall.name) === TestCaseName.it
243+
? TestCaseName.it
244+
: TestCaseName.test,
243245
},
244246
node,
245247
})

tests/valid-title.test.ts

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -601,6 +601,21 @@ ruleTester.run(rule.name, rule, {
601601
describe('foo', () => {
602602
it('', () => {});
603603
});
604+
`,
605+
errors: [
606+
{
607+
messageId: 'emptyTitle',
608+
column: 7,
609+
line: 3,
610+
data: { functionName: 'it' },
611+
},
612+
],
613+
},
614+
{
615+
code: `
616+
describe('foo', () => {
617+
test('', () => {});
618+
});
604619
`,
605620
errors: [
606621
{
@@ -618,7 +633,7 @@ ruleTester.run(rule.name, rule, {
618633
messageId: 'emptyTitle',
619634
column: 1,
620635
line: 1,
621-
data: { functionName: 'test' },
636+
data: { functionName: 'it' },
622637
},
623638
],
624639
},
@@ -630,7 +645,7 @@ ruleTester.run(rule.name, rule, {
630645
messageId: 'emptyTitle',
631646
column: 1,
632647
line: 1,
633-
data: { functionName: 'test' },
648+
data: { functionName: 'it' },
634649
},
635650
],
636651
},
@@ -641,7 +656,7 @@ ruleTester.run(rule.name, rule, {
641656
messageId: 'emptyTitle',
642657
column: 1,
643658
line: 1,
644-
data: { functionName: 'test' },
659+
data: { functionName: 'it' },
645660
},
646661
],
647662
},

0 commit comments

Comments
 (0)