examples: using planetscale's vitess-operator #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthi
reviewed
May 6, 2020
| name: example | ||
| spec: | ||
| images: | ||
| vtctld: us.gcr.io/planetscale-vitess/lite:2020-04-24.228e6fe |
There was a problem hiding this comment.
Any particular reason to pin the version? Local examples run against latest code/build.
examples/operator/operator.yaml
Outdated
| tabletPools: | ||
| description: TabletPools specify groups of tablets in | ||
| a given cell with a certain tablet type and a shared | ||
| configuration template. There |
There was a problem hiding this comment.
Here we seem to always use the latest image.
|
The helm charts should be deprecated, they're not a viable way to run Vitess |
enisoc
reviewed
May 7, 2020
| @@ -1,6 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Why are files being removed from examples/local in this PR? Is it related?
examples/operator/README.txt
Outdated
| @@ -0,0 +1,43 @@ | |||
| minikube start --cpus=8 --memory=11000 --disk-size=50g --kubernetes-version=v1.14.9 | |||
There was a problem hiding this comment.
Should we clean this up into a README.md before merging?
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-operator-example
branch
from
8ba79c3
to
5e3bd8e
Compare
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-operator-example
branch
from
2980487
to
0ee734e
Compare
|
@sougou I've created a tag so we can pin the operator image too now: |
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the vitess example deployed against PlanetScale's operator.
The operator is much faster and feels more stable than the helm charts. Until we find a more committed maintainer for the helm charts, I feel like this should be the recommended way to use vitess on Kubernetes.