-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: using planetscale's vitess-operator #6154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
name: example | ||
spec: | ||
images: | ||
vtctld: us.gcr.io/planetscale-vitess/lite:2020-04-24.228e6fe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to pin the version? Local examples run against latest code/build.
examples/operator/operator.yaml
Outdated
tabletPools: | ||
description: TabletPools specify groups of tablets in | ||
a given cell with a certain tablet type and a shared | ||
configuration template. There |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we seem to always use the latest image.
The helm charts should be deprecated, they're not a viable way to run Vitess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,6 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are files being removed from examples/local in this PR? Is it related?
examples/operator/README.txt
Outdated
@@ -0,0 +1,43 @@ | |||
minikube start --cpus=8 --memory=11000 --disk-size=50g --kubernetes-version=v1.14.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clean this up into a README.md before merging?
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
8ba79c3
to
5e3bd8e
Compare
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
2980487
to
0ee734e
Compare
@sougou I've created a tag so we can pin the operator image too now:
|
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the vitess example deployed against PlanetScale's operator.
The operator is much faster and feels more stable than the helm charts. Until we find a more committed maintainer for the helm charts, I feel like this should be the recommended way to use vitess on Kubernetes.