fix: re-encode url to prevent fs.allow bypass (fixes #8498) #8979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think this fix is not the ideal way but at least it works.
The reason why #8498 (comment) was happening is:
%252ffoo.txt
=>%2ffoo.txt
)%2ffoo.txt
)%2ffoo.txt
=>/foo.txt
)/foo.txt
)The file path mapped from URL is different between 2 and 4.
This PR adds encode after 2. (
%2ffoo.txt
=>%252ffoo.txt
)fixes #8498
refs #8804
refs lukeed/sirv#139
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).