fix: /@fs/ dir traversal with escaped chars (fixes #8498) #8804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was happening becasue Vite uses
decodeURI
and sirv usesdecodeURIComponent
.vite/packages/vite/src/node/server/middlewares/static.ts
Line 83 in e53c029
vite/packages/vite/src/node/server/middlewares/static.ts
Line 126 in e53c029
https://github.com/lukeed/sirv/blob/886cc962a345780cd78f8910cdcf218db2a8d955/packages/sirv/index.js#L171
Maybe sirv should use
decodeURI
instead ofdecodeURIComponent
. But I think changing it have a possibility to break Vite somewhere. So I chose to do like this PR.fixes #8498
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).