Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-app): improve non-empty message for current dir #3117

Merged
merged 2 commits into from
Apr 24, 2021
Merged

feat(create-app): improve non-empty message for current dir #3117

merged 2 commits into from
Apr 24, 2021

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Apr 23, 2021 •
edited
Loading

Description

The user is greeted with the following message if he/she attempts to create a project in the current directory that is non-empty:-

Target directory . is not empty.

This PR aims at improving the message.

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature (Enhancement)
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 23, 2021
patak-dev
patak-dev requested changes Apr 24, 2021
View reviewed changes
packages/create-app/index.js Outdated Show resolved Hide resolved
patak-dev
patak-dev requested changes Apr 24, 2021
View reviewed changes
packages/create-app/index.js Outdated Show resolved Hide resolved
@patak-dev patak-dev changed the title feat(create-app): better prompt message feat(create-app): improve non-empty message for current dir Apr 24, 2021
@patak-dev patak-dev merged commit c0a0a84 into vitejs:main Apr 24, 2021
@patak-dev
Copy link
Member

Thanks for the PR @jamesgeorge007!

@jamesgeorge007 jamesgeorge007 deleted the prompt-message branch April 24, 2021 09:18
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
@jamesgeorge007 @Shinigami92 @TobiasMelen
feat(create-app): improve non-empty message for current dir (vitejs#3117
f30e790 
)

Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @patak-dev @Shinigami92