Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 28, 2025

I noticed a following config crashes on rolldown-vite
https://stackblitz.com/edit/vitejs-rolldown-vite-bq4yd9u3?file=vite.config.ts

import { defineConfig } from 'vite';

export default defineConfig({
  ssr: {
    external: true,
  },
  environments: {
    ssr: {
      resolve: {
        external: ['node:path'],
      },
    },
  },
});
$ vite
...
error when starting dev server:
Error: Value is non of these types `True`, `Array<T>`,  on BindingViteResolvePluginConfig.external
    at napi_create_error (/tmp/rolldown-1.0.0-beta.52/node_modules/.pnpm/@emnapi+core@1.7.1/node_modules/@emnapi/core/dist/emnapi-

I think this is rather unusual setup, but Vitest happens to have a test test failing due to this vitest-dev/vitest#9121 (comment).

@sapphi-red
Copy link
Member

/ecosystem-ci run

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vite@21164

commit: 70d41bb

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on bccd855: Open

suite result latest scheduled
analogjs failure failure
astro failure failure
react-router success ⏹️ cancelled
qwik failure failure
unocss success failure
storybook failure failure
vike failure failure
vite-plugin-cloudflare failure failure

histoire, laravel, marko, one, nuxt, sveltekit, ladle, quasar, vite-plugin-pwa, rakkas, vite-plugin-vue, vite-plugin-react, vitest, vite-plugin-svelte, vite-plugin-rsc, vitepress, vite-setup-catalogue, waku, vuepress, vite-environment-examples

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 1, 2025
@sapphi-red sapphi-red merged commit 5ef557a into vitejs:main Dec 1, 2025
27 of 28 checks passed
@hi-ogawa hi-ogawa deleted the 11-28-fix_fix_external_true_merging branch December 1, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority) trigger: preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants