Skip to content

refactor: remove patchPlugins #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sapphi-red
Copy link
Member

Description

I simply resolved the TODO and ran the tests and it passed.
But after doing that I noticed that there's still some config references in our internal plugins, should we remove all of these before doing this PR?

if (!config.assetsInclude(cleanUrl(id)) && !urlRE.test(id)) {

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) feat: environment API Vite Environment API labels Oct 23, 2024
@patak-dev
Copy link
Member

Yes, we aren't testing with sharedConfig right now. We could have an option to force it for testing locally maybe. For reference, this was added here:

@sapphi-red sapphi-red marked this pull request as draft October 24, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: environment API Vite Environment API p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants