fix(hmr): don't try to rewrite imports for direct CSS soft invalidation #18252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: css
feat: hmr
p3-downstream-blocker
|
|
sapphi-red
force-pushed
the
fix/dont-try-to-rewrite-imports-for-direct-css-softinvalidation
branch
from
b6d969e
to
cb40cb5
Compare
bluwy
reviewed
Oct 2, 2024
bluwy
approved these changes
Oct 3, 2024
sapphi-red
deleted the
fix/dont-try-to-rewrite-imports-for-direct-css-softinvalidation
branch
sapphi-red
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a direct CSS is soft invalidated and has a content that fails to parse by
es-module-lexer(this only happens some times as ex-module-lexer is quite relax with invalid syntaxes), Vite failed to load that file after a refresh.A direct CSS file is soft invalidated when the file depends on a JS file. This happens if a file included in tailwind's
contentoption is updated. For example, the reproduction in the issue hasassets/custom.cssand is imported byapp.vueand that is included by tailwind'scontentoption.fixes nuxt/nuxt#26454