Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #16471 (comment) (removed
false
because it's confusing)This change is what I figured
future
options could be. We can discuss whether this is what we want or not here.My idea is that:
future
options contain a list of top-level properties (feature change names), and users have a choice to opt-in to that breaking change.future.<name>?: "warn"
orfuture.<name>?: true
"warn"
variant is used only when we're unsure this is a change we'll land. Users can try out by opting to"warn"
.true
variant is used when we're sure of this change, and you can opt into this breaking change now. Warnings are already emitted regardless of the option, buttrue
would make them hard errors.Reading the major changes documentation, I could probably see why it landed with
future.deprecationWarnings
in the first place, so this PR may make that page a little odd. My suggestion (if we go along with this) is that in the major changes page:"warn"
, put into the "Future" section (Rename as "Considering" to not overload the future term?)true
, put into the "Current" section