fix(client): fix vite error path #17744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
reviewed
Jul 23, 2024
| @@ -82,7 +84,7 @@ export function errorMiddleware( | |||
| '\\u003c', | |||
| )} | |||
| try { | |||
| const { ErrorOverlay } = await import('/@vite/client') | |||
| const { ErrorOverlay } = await import(${path.posix.join(server.config.base, CLIENT_PUBLIC_PATH)}) | |||
There was a problem hiding this comment.
This is missing quotes around the specifier, you can wrap it with a JSON.stringify() so that it generates quotes and escape them.
bluwy
approved these changes
Jul 23, 2024
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, histoire, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, remix, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress |
patak-dev
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #17656
This pr fix embedded
Viteerror path.