revert: fix(logger): truncate log over 5000 characters long (#16581) #17729
+10
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
approved these changes
Jul 22, 2024
patak-dev
approved these changes
Jul 22, 2024
|
yay! This fixes an issue we have had where the calculation of 5000 lines is wrong because it does not account for escape sequences (which can cause the number of \n characters to be completely independent of the number of successive lines written to the screen). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to alexeyraspopov/picocolors#64, no longer needed to truncate logs over >5K characters long.
It was kind of tricky to add some tests, so I made a related test for ‘picocolors’, which was the root problem. The following is the related PR: