Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): revert eslint 9 upgrade in templates #17511

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

patak-dev
Copy link
Member

Description

Partial revert of #16661, we shouldn't yet update eslint to v9 in the templates because eslint-plugin-react doesn't yet support it.

We're keeping track of the upgrade to v9 in templates here:

Copy link

stackblitz bot commented Jun 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev enabled auto-merge (squash) June 18, 2024 11:29
@ArnaudBarre
Copy link
Member

Thanks!

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to use https://www.npmjs.com/package/@eslint/compat#fixing-plugins to fixup the react plugin. From my perspective, I see the react plugin probably won't support ESLint v9 for a long while, which shouldn't be the reason for blocking the ecosystem. ESLint team has put effort to have a compact layer and we should help to move the ecosystem forward

@patak-dev
Copy link
Member Author

@antfu I think that is a good idea. I'll go ahead and merge this PR because vite.new/react is issuing a lot of warnings. I would support us helping eslint v9 get more adoption, let's discuss that in a future PR.

@patak-dev patak-dev disabled auto-merge June 18, 2024 11:40
@patak-dev patak-dev merged commit 86cf1b4 into main Jun 18, 2024
11 checks passed
@patak-dev patak-dev deleted the fix-create-vite-revert-eslint-9 branch June 18, 2024 11:40
@ArnaudBarre
Copy link
Member

Yeah I mentioned in #12860 that I think adding the compat is better than waiting, I'll take the PR over to release it

@smeng9
Copy link
Contributor

smeng9 commented Jun 18, 2024

The original one should be updated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants