Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip unicode test on windows instead of lowering the Node version #15096

Merged

Conversation

sapphi-red
Copy link
Member

Description

The fix (nodejs/node#50650) for the Windows unicode fs bug (nodejs/node#48673) seems to be not included in the next LTS release (nodejs/node#50682).
This means we'll need to pin the version for at least 2 week more.

I think it's better to skip this (edge case) test rather than running in the older version.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 22, 2023
@patak-dev patak-dev merged commit fd31412 into vitejs:main Nov 22, 2023
10 checks passed
@sapphi-red sapphi-red deleted the test/run-test-on-latest-lts-windows branch November 22, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants