Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): skip url query request (fixes #10863) #10920

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

sapphi-red
Copy link
Member

Description

new URL(/src/${url}, import.meta.url).href; is transformed to import vueUrl from './foo.vue?url'.

./foo.vue?url was not returning url and also was transformed by plugin-vue.

Vue now rejects likely invalid components to prevent mistakes (vuejs/core#6676).
So before Vue 3.2.42, ./foo.vue?url was returning a unintended code and after that the reqeust throws an error.

fixes #10863

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: vue p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 14, 2022
@patak-dev patak-dev merged commit 97d200c into vitejs:main Nov 14, 2022
@sapphi-red sapphi-red deleted the fix/vue-url-query-handling branch November 15, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with vue cannot use import.meta.url object directly - new URL(url, import.meta.url) -
3 participants