Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): add 'assumptions' option #10887

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xiongmao86
Copy link

Description

Babel allows specifying compiler assumptions for generating small output. This pr adds assumptions option to pass to babel transform inside @vitejs/plugin-legacy.

Fixes #6965

Additional context

none


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@xiongmao86
Copy link
Author

When I am trying to write a test, I meet the following questions:

  • Should it reside in playground/vue-legacy?
  • What input code should I choose?
  • Where should I put it so that it will show up in JavaScript code after typescript transpiling?

Can anyone please give me some pointers. Thanks.

@xiongmao86
Copy link
Author

@babel/core and @babel/stand-alone version is newer than Babel 7.13.0, Why the ci test warn that assumptions is not supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying assumptions in @vitejs/plugin-legacy
1 participant