Skip to content

Error logged to console when using manualChunkSplitting and function is used. #13797

Closed
@jafin

Description

Describe the bug

Setup

When you configure vite with splitVendorChunkPlugin()
and configure rollupOptions output manualChunks with a function.

 build: {
        rollupOptions: {
            output: {
                manualChunks: manualChunksFn,
            },
        },
}

function manualChunksFn(id: string) {
// chunklogic
}

Expected:

No console warning about using a function for manualChunks

Actual

Warning logged to console

"(!) the `splitVendorChunk` plugin doesn't have any effect when using the object form of `build.rollupOptions.manualChunks`. Consider using the function form instead.",

This was introduced via #13431
And I believe it just needs an else around the warning to correct.

Reproduction

https://stackblitz.com/edit/vitejs-vite-2epesn?file=vite.config.ts

Steps to reproduce

run npm run build
note output in console logs

docs(chunkSplitting): add manualChunks object form syntax warning when it is used with the splitVendorChunk plugin #13431

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.3 - /usr/local/bin/pnpm
  npmPackages:
    vite: ^4.4.2 => 4.4.3

Used Package Manager

npm

Logs

No response

Validations

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    p3-minor-bugAn edge case that only affects very specific usage (priority)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions