Closed
Description
Describe the bug
Setup
When you configure vite with splitVendorChunkPlugin()
and configure rollupOptions output manualChunks with a function.
build: {
rollupOptions: {
output: {
manualChunks: manualChunksFn,
},
},
}
function manualChunksFn(id: string) {
// chunklogic
}
Expected:
No console warning about using a function for manualChunks
Actual
Warning logged to console
"(!) the `splitVendorChunk` plugin doesn't have any effect when using the object form of `build.rollupOptions.manualChunks`. Consider using the function form instead.",
This was introduced via #13431
And I believe it just needs an else around the warning to correct.
Reproduction
https://stackblitz.com/edit/vitejs-vite-2epesn?file=vite.config.ts
Steps to reproduce
run npm run build
note output in console logs
docs(chunkSplitting): add manualChunks object form syntax warning when it is used with the splitVendorChunk plugin #13431
System Info
System:
OS: Linux 5.0 undefined
CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 0 Bytes / 0 Bytes
Shell: 1.0 - /bin/jsh
Binaries:
Node: 16.20.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.4.2 - /usr/local/bin/npm
pnpm: 8.6.3 - /usr/local/bin/pnpm
npmPackages:
vite: ^4.4.2 => 4.4.3
Used Package Manager
npm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
Activity