fix: restore builtins list

vitejs · Oct 3, 2023 · f8b9adb · f8b9adb
1 parent 104971d
commit f8b9adb
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -94,8 +94,25 @@ const NODE_BUILTIN_NAMESPACE = 'node:'
 const NPM_BUILTIN_NAMESPACE = 'npm:'
 // Supported by Bun
 const BUN_BUILTIN_NAMESPACE = 'bun:'
+//TODO: revisit later to see if the edge case that "compiling using node v12 code to be run in node v16 in the server" is what we intend to support.
+const builtins = new Set([
+  ...builtinModules,
+  'assert/strict',
+  'diagnostics_channel',
+  'dns/promises',
+  'fs/promises',
+  'path/posix',
+  'path/win32',
+  'readline/promises',
+  'stream/consumers',
+  'stream/promises',
+  'stream/web',
+  'timers/promises',
+  'util/types',
+  'wasi',
+])
 // Some runtimes like Bun injects namespaced modules here, which is not a node builtin
-const nodeBuiltins = builtinModules.filter((id) => !id.includes(':'))
+const nodeBuiltins = [...builtins].filter((id) => !id.includes(':'))
 
 // TODO: Use `isBuiltin` from `node:module`, but Deno doesn't support it
 export function isBuiltin(id: string): boolean {