refactor!: remove HotBroadcaster (#19988)

Author: sapphi-red

packages/vite/src/node/server/hmr.ts

@@ -1148,43 +1148,3 @@ export function createServerHotChannel(): ServerHotChannel {
     },
   }
 }
-
-/** @deprecated use `environment.hot` instead */
-export interface HotBroadcaster extends NormalizedHotChannel {
-  readonly channels: NormalizedHotChannel[]
-  /**
-   * A noop.
-   * @deprecated
-   */
-  addChannel(channel: HotChannel): HotBroadcaster
-  close(): Promise<unknown[]>
-}
-
-export function createDeprecatedHotBroadcaster(
-  ws: NormalizedHotChannel,
-): HotBroadcaster {
-  const broadcaster: HotBroadcaster = {
-    on: ws.on,
-    off: ws.off,
-    listen: ws.listen,
-    send: ws.send,
-    setInvokeHandler: ws.setInvokeHandler,
-    handleInvoke: async () => ({
-      error: {
-        name: 'TransportError',
-        message: 'handleInvoke not implemented',
-        stack: new Error().stack,
-      },
-    }),
-    get channels() {
-      return [ws]
-    },
-    addChannel() {
-      return broadcaster
-    },
-    close() {
-      return Promise.all(broadcaster.channels.map((channel) => channel.close()))
-    },
-  }
-  return broadcaster
-}

packages/vite/src/node/server/index.ts

@@ -93,12 +93,8 @@ import { ModuleGraph } from './mixedModuleGraph'
 import type { ModuleNode } from './mixedModuleGraph'
 import { notFoundMiddleware } from './middlewares/notFound'
 import { buildErrorMessage, errorMiddleware } from './middlewares/error'
-import type { HmrOptions, HotBroadcaster } from './hmr'
-import {
-  createDeprecatedHotBroadcaster,
-  handleHMRUpdate,
-  updateModules,
-} from './hmr'
+import type { HmrOptions, NormalizedHotChannel } from './hmr'
+import { handleHMRUpdate, updateModules } from './hmr'
 import { openBrowser as _openBrowser } from './openBrowser'
 import type { TransformOptions, TransformResult } from './transformRequest'
 import { transformRequest } from './transformRequest'
@@ -284,12 +280,10 @@ export interface ViteDevServer {
    */
   ws: WebSocketServer
   /**
-   * HMR broadcaster that can be used to send custom HMR messages to the client
-   *
-   * Always sends a message to at least a WebSocket client. Any third party can
-   * add a channel to the broadcaster to process messages
+   * An alias to `server.environments.client.hot`.
+   * If you want to interact with all environments, loop over `server.environments`.
    */
-  hot: HotBroadcaster
+  hot: NormalizedHotChannel
   /**
    * Rollup plugin container that can run plugin hooks on a given file
    */
@@ -573,7 +567,7 @@ export async function _createServer(
     httpServer,
     watcher,
     ws,
-    hot: createDeprecatedHotBroadcaster(ws),
+    hot: ws,
 
     environments,
     pluginContainer,