From 9babef54c6d25c1948c95812b7ea95d618214736 Mon Sep 17 00:00:00 2001 From: Bjorn Lu Date: Thu, 26 Oct 2023 16:08:03 +0800 Subject: [PATCH] fix: skip watchPackageDataPlugin for worker builds (#14762) --- packages/vite/src/node/build.ts | 9 --------- packages/vite/src/node/plugins/index.ts | 3 ++- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts index ee8993a9457118..49617b16de9ac2 100644 --- a/packages/vite/src/node/build.ts +++ b/packages/vite/src/node/build.ts @@ -893,15 +893,6 @@ export function onRollupWarning( return } - // Rollup tracks the build phase slightly earlier before `buildEnd` is called, - // so there's a chance we can call `this.addWatchFile` in the invalid phase. Skip for now. - if ( - warning.plugin === 'vite:worker-import-meta-url' && - warning.pluginCode === 'INVALID_ROLLUP_PHASE' - ) { - return - } - if (warningIgnoreList.includes(warning.code!)) { return } diff --git a/packages/vite/src/node/plugins/index.ts b/packages/vite/src/node/plugins/index.ts index 4279d99484d379..bb276d21c1ea0d 100644 --- a/packages/vite/src/node/plugins/index.ts +++ b/packages/vite/src/node/plugins/index.ts @@ -32,6 +32,7 @@ export async function resolvePlugins( postPlugins: Plugin[], ): Promise { const isBuild = config.command === 'build' + const isWorker = config.isWorker const buildPlugins = isBuild ? await (await import('../build')).resolveBuildPlugins(config) : { pre: [], post: [] } @@ -47,7 +48,7 @@ export async function resolvePlugins( ] : []), isBuild ? metadataPlugin() : null, - watchPackageDataPlugin(config.packageCache), + !isWorker ? watchPackageDataPlugin(config.packageCache) : null, preAliasPlugin(config), aliasPlugin({ entries: config.resolve.alias }), ...prePlugins,